remove legacy recovery tests by tjungblu · Pull Request #27917 · openshift/origin

tjungblu · 2023-05-11T13:54:47Z

cleaning up the old tests and the bastion ssh code

dusk125 · 2023-05-11T14:42:42Z

/lgtm

hasbro17 · 2023-05-14T22:59:36Z

-	"[sig-arch][Feature:ClusterUpgrade] Cluster should be upgradeable after finishing upgrade [Late][Suite:upgrade]": "",
-
-	"[sig-arch][Feature:ClusterUpgrade] Cluster should be upgradeable before beginning upgrade [Early][Suite:upgrade]": "",


This is not related to our cleanup right? And the test still seems to be there:

origin/test/e2e/upgrade/upgrade.go

Lines 142 to 146 in 2d41e52

var _ = g.Describe("[sig-arch][Feature:ClusterUpgrade]", func() {

f := framework.NewDefaultFramework("cluster-upgrade")

f.SkipNamespaceCreation = true

g.It("Cluster should be upgradeable before beginning upgrade [Early][Suite:upgrade]", func() {

We might want to double check if we aren't disabling this unintentionally.

good point, no idea how that got into it...

okay that's a really weird issue, it's a completely different folder. On the master branch I don't have that change generated.

there was an implicit dependency on the e2e module, I've added it manually again now

hasbro17 · 2023-05-15T18:02:45Z

/approve
Needs a go mod vendor update I think.
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/27917/pull-ci-openshift-origin-master-verify-deps/1658045980387315712

tjungblu · 2023-05-16T06:56:53Z

@bparees could you please take a look when you have some time?
cc @soltysh because I also see those touching some vendor k8s tests

We have successfully replaced the existing tests with two new presubmits:
https://sippy.dptools.openshift.org/sippy-ng/tests/Presubmits/analysis?test=%5Bsig-etcd%5D%5BFeature%3ADisasterRecovery%5D%5BSuite%3Aopenshift%2Fetcd%2Frecovery%5D%5BTimeout%3A2h%5D%20%5BFeature%3AEtcdRecovery%5D%5BDisruptive%5D%20Recover%20with%20snapshot%20with%20two%20unhealthy%20nodes%20and%20lost%20quorum%20%5BSerial%5D

https://sippy.dptools.openshift.org/sippy-ng/tests/Presubmits/analysis?test=%5Bsig-etcd%5D%5BFeature%3ADisasterRecovery%5D%5BSuite%3Aopenshift%2Fetcd%2Frecovery%5D%5BTimeout%3A30m%5D%20%5BFeature%3AEtcdRecovery%5D%5BDisruptive%5D%20Restore%20snapshot%20from%20node%20on%20another%20single%20unhealthy%20node%20%5BSerial%5D

which are running now, which means we can clean this old bastion-ssh based tests up :)

bparees · 2023-05-16T13:12:42Z

/approve

dusk125 · 2023-05-17T13:29:07Z

/lgtm

tjungblu · 2023-05-17T13:42:21Z

/retest-required

openshift-ci-robot · 2023-05-17T21:23:47Z

/retest-required

Remaining retests: 0 against base HEAD 41e5e45 and 2 for PR HEAD cb558e7 in total

openshift-ci-robot · 2023-05-18T12:23:49Z

/retest-required

Remaining retests: 0 against base HEAD 3fc884b and 1 for PR HEAD cb558e7 in total

openshift-ci-robot · 2023-05-18T20:21:11Z

/retest-required

Remaining retests: 0 against base HEAD 7fe48ef and 0 for PR HEAD cb558e7 in total

soltysh · 2023-05-18T20:45:49Z

/hold
to merge #27894 first

soltysh · 2023-05-19T08:29:35Z

/hold cancel
the other merged
@tjungblu you'll need to rebase, sorry about it 😓

dusk125 · 2023-05-30T13:38:13Z

/lgtm

openshift-ci · 2023-05-30T13:42:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, dusk125, hasbro17, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tjungblu · 2023-05-30T13:47:24Z

/retest-required

openshift-ci-robot · 2023-05-30T18:56:51Z

/retest-required

Remaining retests: 0 against base HEAD eb94825 and 2 for PR HEAD 57f7006 in total

openshift-ci · 2023-05-30T21:14:57Z

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn-etcd-scaling	`cb558e7`	link	false	`/test e2e-azure-ovn-etcd-scaling`
ci/prow/e2e-gcp-ovn-etcd-scaling	`cb558e7`	link	false	`/test e2e-gcp-ovn-etcd-scaling`
ci/prow/e2e-vsphere-ovn-etcd-scaling	`cb558e7`	link	false	`/test e2e-vsphere-ovn-etcd-scaling`
ci/prow/e2e-agnostic-ovn-cmd	`57f7006`	link	false	`/test e2e-agnostic-ovn-cmd`
ci/prow/e2e-aws-ovn-single-node-upgrade	`57f7006`	link	false	`/test e2e-aws-ovn-single-node-upgrade`
ci/prow/e2e-aws-ovn-single-node-serial	`57f7006`	link	false	`/test e2e-aws-ovn-single-node-serial`
ci/prow/e2e-openstack-ovn	`57f7006`	link	false	`/test e2e-openstack-ovn`
ci/prow/e2e-aws-ovn-upgrade	`57f7006`	link	false	`/test e2e-aws-ovn-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci Bot requested review from coreydaley and hasbro17 May 11, 2023 13:59

openshift-ci Bot assigned dusk125 May 11, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2023

hasbro17 reviewed May 14, 2023

View reviewed changes

tjungblu force-pushed the recovery_suite_asserts branch from b4d1d4e to d25b76b Compare May 15, 2023 09:06

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2023

tjungblu requested a review from hasbro17 May 15, 2023 09:41

tjungblu force-pushed the recovery_suite_asserts branch from 4bfba18 to cb558e7 Compare May 16, 2023 06:28

openshift-ci Bot added the vendor-update Touching vendor dir or related files label May 16, 2023

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2023

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2023

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2023

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2023

tjungblu added 3 commits May 30, 2023 11:04

remove legacy recovery tests

91c5e4f

explicitly add upgrade tests back

29715ed

update go.mod and vendor

57f7006

tjungblu force-pushed the recovery_suite_asserts branch from cb558e7 to 57f7006 Compare May 30, 2023 09:07

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 30, 2023

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023

openshift-merge-robot merged commit c176d05 into openshift:master May 30, 2023

		"[sig-arch][Feature:ClusterUpgrade] Cluster should be upgradeable after finishing upgrade [Late][Suite:upgrade]": "",

		"[sig-arch][Feature:ClusterUpgrade] Cluster should be upgradeable before beginning upgrade [Early][Suite:upgrade]": "",

	var _ = g.Describe("[sig-arch][Feature:ClusterUpgrade]", func() {
	f := framework.NewDefaultFramework("cluster-upgrade")
	f.SkipNamespaceCreation = true

	g.It("Cluster should be upgradeable before beginning upgrade [Early][Suite:upgrade]", func() {

Uh oh!

Conversation

tjungblu commented May 11, 2023

Uh oh!

dusk125 commented May 11, 2023

Uh oh!

hasbro17 May 14, 2023

Choose a reason for hiding this comment

Uh oh!

tjungblu May 15, 2023

Choose a reason for hiding this comment

Uh oh!

tjungblu May 15, 2023

Choose a reason for hiding this comment

Uh oh!

tjungblu May 15, 2023

Choose a reason for hiding this comment

Uh oh!

tjungblu May 15, 2023

Choose a reason for hiding this comment

Uh oh!

hasbro17 commented May 15, 2023

Uh oh!

tjungblu commented May 16, 2023

Uh oh!

bparees commented May 16, 2023

Uh oh!

dusk125 commented May 17, 2023

Uh oh!

tjungblu commented May 17, 2023

Uh oh!

openshift-ci-robot commented May 17, 2023

Uh oh!

openshift-ci-robot commented May 18, 2023

Uh oh!

openshift-ci-robot commented May 18, 2023

Uh oh!

soltysh commented May 18, 2023

Uh oh!

soltysh commented May 19, 2023

Uh oh!

dusk125 commented May 30, 2023

Uh oh!

openshift-ci Bot commented May 30, 2023

Uh oh!

tjungblu commented May 30, 2023

Uh oh!

openshift-ci-robot commented May 30, 2023

Uh oh!

openshift-ci Bot commented May 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants