Add new tests for baremetal IPI platform by andfasano · Pull Request #25853 · openshift/origin

andfasano · 2021-02-03T16:38:37Z

This PR adds some new basic tests for the baremetal IPI platform, so that it could be possible to integrate them in the current CI/release builds for the baremetal IPI platform.

Tests are referring the following enhancements:

CI baremetal workflow:

https://github.com/openshift/release/blob/master/ci-operator/step-registry/baremetalds/e2e/baremetalds-e2e-workflow.yaml

This is just an initial PR to begin landing tests for the baremetal IPI platform and clear out the required technical details.

andfasano · 2021-02-03T16:39:55Z

/assign @deads2k

andfasano · 2021-02-10T16:17:23Z

/retest

stbenjam · 2021-02-12T12:13:30Z

Will enabling e2e-metal-ipi on this repo let us see the tests pass?

andfasano · 2021-02-12T13:49:03Z

Will enabling e2e-metal-ipi on this repo let us see the tests pass?

Good idea, openshift/release#15816

stbenjam · 2021-02-25T18:57:05Z

/test e2e-metal-ipi

stbenjam · 2021-02-25T19:25:05Z

Can we get an OWNERS file added to the baremetal directories?

Initial tests look fine, but plan is to add more? I'd like us to make sure control plane hosts are adopted correctly and reflect "Externally provisioned." And if there's no existing test for this here, make sure that all our machines have a node ref.

stbenjam · 2021-02-25T20:00:00Z

/test e2e-metal-ipi

andfasano · 2021-03-01T08:29:33Z

/test e2e-metal-ipi

openshift-ci-robot · 2021-03-01T08:29:45Z

@andfasano: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test e2e-agnostic-cmd
/test e2e-aws
/test e2e-aws-csi
/test e2e-aws-disruptive
/test e2e-aws-fips
/test e2e-aws-image-registry
/test e2e-aws-jenkins
/test e2e-aws-multitenant
/test e2e-aws-ovn
/test e2e-aws-proxy
/test e2e-aws-serial
/test e2e-aws-upgrade
/test e2e-azure
/test e2e-gcp
/test e2e-gcp-builds
/test e2e-gcp-csi
/test e2e-gcp-disruptive
/test e2e-gcp-image-ecosystem
/test e2e-gcp-upgrade
/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-virtualmedia
/test e2e-openstack
/test e2e-openstack-serial
/test e2e-vsphere
/test images
/test okd-e2e-gcp
/test verify
/test verify-deps
/test extended_gssapi
/test extended_ldap_groups
/test extended_networking

Use /test all to run the following jobs:

pull-ci-openshift-origin-master-e2e-agnostic-cmd
pull-ci-openshift-origin-master-e2e-aws-csi
pull-ci-openshift-origin-master-e2e-aws-disruptive
pull-ci-openshift-origin-master-e2e-aws-fips
pull-ci-openshift-origin-master-e2e-aws-serial
pull-ci-openshift-origin-master-e2e-gcp
pull-ci-openshift-origin-master-e2e-gcp-builds
pull-ci-openshift-origin-master-e2e-gcp-csi
pull-ci-openshift-origin-master-e2e-gcp-disruptive
pull-ci-openshift-origin-master-e2e-gcp-upgrade
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
pull-ci-openshift-origin-master-images
pull-ci-openshift-origin-master-verify
pull-ci-openshift-origin-master-verify-deps

Details

In response to this:

/test ci/prow/e2e-metal-ipi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andfasano · 2021-03-01T08:33:15Z

Looks like the new two tests (tagged with [sig-installer][Feature:baremetal]) are correctly executed and passing during the e2e-metal-ipi job

stbenjam · 2021-03-01T11:31:04Z

Looks like the new two tests (tagged with [sig-installer][Feature:baremetal]) are correctly executed and passing during the e2e-metal-ipi job

Nice! Did you see my comment above, specifically the OWNERS file so we can add tests later?

#25853 (comment)

andfasano · 2021-03-01T15:58:19Z

Looks like the new two tests (tagged with [sig-installer][Feature:baremetal]) are correctly executed and passing during the e2e-metal-ipi job

Nice! Did you see my comment above, specifically the OWNERS file so we can add tests later?

#25853 (comment)

Thanks, added

andfasano · 2021-03-02T09:15:49Z

/test all

openshift-ci-robot · 2021-03-02T09:16:01Z

@andfasano: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test e2e-agnostic-cmd
/test e2e-aws
/test e2e-aws-csi
/test e2e-aws-disruptive
/test e2e-aws-fips
/test e2e-aws-image-registry
/test e2e-aws-jenkins
/test e2e-aws-multitenant
/test e2e-aws-ovn
/test e2e-aws-proxy
/test e2e-aws-serial
/test e2e-aws-upgrade
/test e2e-azure
/test e2e-gcp
/test e2e-gcp-builds
/test e2e-gcp-csi
/test e2e-gcp-disruptive
/test e2e-gcp-image-ecosystem
/test e2e-gcp-upgrade
/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-virtualmedia
/test e2e-openstack
/test e2e-openstack-serial
/test e2e-vsphere
/test images
/test okd-e2e-gcp
/test verify
/test verify-deps
/test extended_gssapi
/test extended_ldap_groups
/test extended_networking

Use /test all to run the following jobs:

pull-ci-openshift-origin-master-e2e-agnostic-cmd
pull-ci-openshift-origin-master-e2e-aws-csi
pull-ci-openshift-origin-master-e2e-aws-disruptive
pull-ci-openshift-origin-master-e2e-aws-fips
pull-ci-openshift-origin-master-e2e-aws-serial
pull-ci-openshift-origin-master-e2e-gcp
pull-ci-openshift-origin-master-e2e-gcp-builds
pull-ci-openshift-origin-master-e2e-gcp-csi
pull-ci-openshift-origin-master-e2e-gcp-disruptive
pull-ci-openshift-origin-master-e2e-gcp-upgrade
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
pull-ci-openshift-origin-master-images
pull-ci-openshift-origin-master-verify
pull-ci-openshift-origin-master-verify-deps

Details

In response to this:

/test pj-rehearse

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andfasano · 2021-03-02T10:26:42Z

/test e2e-metal-ipi

stbenjam · 2021-03-02T11:36:31Z

/retest

stbenjam · 2021-03-02T11:46:55Z

/lgtm

stbenjam · 2021-03-09T16:59:06Z

/lgtm

stbenjam · 2021-03-11T12:07:30Z

Could we get another review please @deads2k?

stbenjam · 2021-03-15T15:19:26Z

/lgtm

deads2k · 2021-03-15T17:36:59Z

/approve

deads2k · 2021-03-15T17:37:02Z

/lgtm

openshift-ci-robot · 2021-03-15T17:37:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, deads2k, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/extended/OWNERS~~ [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-03-15T23:25:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-15T23:38:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-16T01:48:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

stbenjam · 2021-03-16T11:51:22Z

/test e2e-gcp-builds

andfasano · 2021-03-16T16:26:50Z

/test e2e-gcp-builds
/test e2e-gcp-disruptive

andfasano · 2021-03-17T08:29:14Z

/test e2e-gcp-builds

andfasano · 2021-03-17T16:44:18Z

/test e2e-gcp
/test e2e-gcp-upgrade

andfasano · 2021-03-18T08:34:07Z

/test e2e-gcp-upgrade

stbenjam · 2021-03-18T11:02:41Z

/test e2e-gcp-upgrade

I don't know if this is ever going to pass. It's been failing since 2021-03-15

@deads2k It seems unrelated to our PR, is someone looking at this or can you override it?

stbenjam · 2021-03-19T12:19:10Z

/test e2e-gcp-upgrade

stbenjam · 2021-03-19T16:46:27Z

@deads2k Could you help here? e2e-gcp-upgrade has succeeded twice now, but it takes so much time that prow says it wants to retest 8 jobs... and then e2e-gcp-upgrade might fail again, causing the cycle to repeat.

How does anything land in this repo? CI has been trying since 3/15 to land this PR.

stbenjam · 2021-03-19T21:33:47Z

/retest

stbenjam · 2021-03-20T17:53:39Z

/retest

sigh

stbenjam · 2021-03-20T20:21:55Z

/test e2e-aws-serial

stbenjam · 2021-03-21T01:32:38Z

/retest

stbenjam · 2021-03-21T03:05:30Z

/retest

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2021

openshift-ci-robot requested review from mfojtik and smarterclayton February 3, 2021 16:38

openshift-ci-robot assigned deads2k Feb 3, 2021

andfasano changed the title ~~[WIP] Add new tests for baremetal platform~~ [WIP] Add new tests for baremetal IPI platform Feb 3, 2021

andfasano force-pushed the baremetal-tests branch from 03efd05 to 5d5a9b0 Compare February 12, 2021 11:44

andfasano changed the title ~~[WIP] Add new tests for baremetal IPI platform~~ Add new tests for baremetal IPI platform Feb 12, 2021

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2021

andfasano closed this Feb 12, 2021

andfasano reopened this Feb 12, 2021

andfasano mentioned this pull request Feb 12, 2021

openshift/origin: add tests for metal ipi platform openshift/release#15816

Merged

andfasano force-pushed the baremetal-tests branch from 5d5a9b0 to 536e093 Compare March 1, 2021 15:57

openshift-ci-robot assigned stbenjam Mar 2, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2021

deads2k reviewed Mar 15, 2021

View reviewed changes

Comment thread test/extended/baremetal/hosts.go Outdated

Add new tests for baremetal platform

d65cb9d

andfasano force-pushed the baremetal-tests branch from c4330c2 to d65cb9d Compare March 15, 2021 15:14

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2021

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2021

openshift-merge-robot merged commit 2de32d9 into openshift:master Mar 21, 2021

Conversation

andfasano commented Feb 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andfasano commented Feb 3, 2021

Uh oh!

andfasano commented Feb 10, 2021

Uh oh!

stbenjam commented Feb 12, 2021

Uh oh!

andfasano commented Feb 12, 2021

Uh oh!

stbenjam commented Feb 25, 2021

Uh oh!

stbenjam commented Feb 25, 2021

Uh oh!

stbenjam commented Feb 25, 2021

Uh oh!

andfasano commented Mar 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 1, 2021

Uh oh!

andfasano commented Mar 1, 2021

Uh oh!

stbenjam commented Mar 1, 2021

Uh oh!

andfasano commented Mar 1, 2021

Uh oh!

andfasano commented Mar 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 2, 2021

Uh oh!

andfasano commented Mar 2, 2021

Uh oh!

stbenjam commented Mar 2, 2021

Uh oh!

stbenjam commented Mar 2, 2021

Uh oh!

stbenjam commented Mar 9, 2021

Uh oh!

stbenjam commented Mar 11, 2021

Uh oh!

Uh oh!

stbenjam commented Mar 15, 2021

Uh oh!

deads2k commented Mar 15, 2021

Uh oh!

deads2k commented Mar 15, 2021

Uh oh!

openshift-ci-robot commented Mar 15, 2021

Uh oh!

openshift-bot commented Mar 15, 2021

Uh oh!

openshift-bot commented Mar 15, 2021

Uh oh!

openshift-bot commented Mar 16, 2021

Uh oh!

stbenjam commented Mar 16, 2021

Uh oh!

andfasano commented Mar 16, 2021

Uh oh!

andfasano commented Mar 17, 2021

Uh oh!

andfasano commented Mar 17, 2021

Uh oh!

andfasano commented Mar 18, 2021

Uh oh!

stbenjam commented Mar 18, 2021

Uh oh!

stbenjam commented Mar 19, 2021

Uh oh!

stbenjam commented Mar 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stbenjam commented Mar 19, 2021

Uh oh!

stbenjam commented Mar 20, 2021

Uh oh!

andfasano commented Feb 3, 2021 •

edited

Loading

andfasano commented Mar 1, 2021 •

edited

Loading

andfasano commented Mar 2, 2021 •

edited

Loading

stbenjam commented Mar 19, 2021 •

edited

Loading