OCPBUGS-24587,OCPBUGS-28744: Synchronize From Upstream Repositories by openshift-bot · Pull Request #679 · openshift/operator-framework-olm

openshift-bot · 2024-02-02T18:35:46Z

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date	Commit	Author	Message
2024-01-23 15:23:09	operator-framework/operator-lifecycle-manager@1bb6009	dependabot[bot]	build(deps): bump github.com/docker/docker (#3080)
2024-02-02 16:05:43	operator-framework/operator-lifecycle-manager@1e0324c	Steve Kuznetsov	olm,catalog: only validate the resources we label (#3165)
2024-02-02 16:40:15	operator-framework/operator-lifecycle-manager@54da66a	Anik Bhattacharjee	Clear (existing) error cond from Subscription, once error resolved (#3166)
2024-02-05 19:20:27	operator-framework/operator-lifecycle-manager@6e3f051	Anik Bhattacharjee	Reflect BundleUnpacking cond removal in missed e2e test (#3170)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/cc @openshift/openshift-team-operator-runtime
/cc @openshift/openshift-team-operator-ecosystem

openshift-ci-robot · 2024-02-02T18:35:49Z

@openshift-bot: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-02-02T18:36:00Z

@openshift-bot: GitHub didn't allow me to request PR reviews from the following users: openshift/openshift-team-operator-ecosystem.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2024-02-02T18:36:20Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2024-02-02T18:36:20Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

stevekuznetsov · 2024-02-02T19:20:04Z

/retitle OCPBUGS-28744: NO-ISSUE: Synchronize From Upstream Repositories

openshift-ci-robot · 2024-02-02T19:20:12Z

@openshift-bot: This pull request references Jira Issue OCPBUGS-28744, which is invalid:

expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

stevekuznetsov · 2024-02-02T19:20:38Z

/retitle OCPBUGS-24587,OCPBUGS-28744: NO-ISSUE: Synchronize From Upstream Repositories

openshift-ci-robot · 2024-02-02T19:20:46Z

@openshift-bot: This pull request references Jira Issue OCPBUGS-24587, which is invalid:

expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-28744, which is invalid:

expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

stevekuznetsov · 2024-02-02T19:23:14Z

/jira refresh

openshift-ci-robot · 2024-02-02T19:23:23Z

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-24587, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

This pull request references Jira Issue OCPBUGS-28744, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-02T21:46:11Z

/retest-required

Remaining retests: 0 against base HEAD ebfa3c1 and 2 for PR HEAD a788fc1 in total

anik120

/retitle OCPBUGS-24587,OCPBUGS-28744: Synchronize From Upstream Repositories

anik120 · 2024-02-02T21:53:20Z

/retest

openshift-ci-robot · 2024-02-03T00:04:55Z

@openshift-bot: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Xia-Zhao-rh · 2024-02-04T10:24:48Z

/label qe-approved
Test PASS https://issues.redhat.com/browse/OCPBUGS-24587

rashmigottipati · 2024-02-04T20:37:20Z

/test e2e-gcp-olm

stevekuznetsov · 2024-02-05T14:53:57Z

/retitle OCPBUGS-24587,OCPBUGS-28744: Synchronize From Upstream Repositories

openshift-ci-robot · 2024-02-05T14:55:25Z

@openshift-bot: This pull request references Jira Issue OCPBUGS-24587, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Xia-Zhao-rh

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-28744, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

stevekuznetsov · 2024-02-05T14:59:55Z

/retest

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 23.0.3+incompatible to 24.0.7+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v23.0.3...v24.0.7) Upstream-repository: operator-lifecycle-manager Upstream-commit: 1bb6009089171393c94c944257ec7b4d06834551 --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* *: don't duplicate owner references Signed-off-by: Steve Kuznetsov <skuznets@redhat.com> * olm,catalog: only validate the resources we label Each controller can see (and, therefore, can label) a separate set of GVRs. When we start up, detecting if any OLM-related resource needs labelling means that one controller may start, detect a need for labelling a resource it cannot itself label, detect that it's labelled everything it can, and restart. If the other operator is stuck for whatever reason, this leads the first controller to enter CrashLoopBackOff and break OCP upgrade. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com> * catalog: prune duplicate OwnerReferences on Services Signed-off-by: Steve Kuznetsov <skuznets@redhat.com> --------- Signed-off-by: Steve Kuznetsov <skuznets@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 1e0324c128d3095e2f1a66e5c27cfa617eeea876

…3166) The func `removeSubsCond` takes in a list of pointers to Subscription objects, modifies the objects that the pointers point to, but return a new list of those pointers. A [PR](operator-framework/operator-lifecycle-manager#2942) included in the v0.25.0 release [changed the way the output of that function was being used](https://github.com/operator-framework/operator-lifecycle-manager/pull/2942/files#diff-a1760d9b7ac1e93734eea675d8d8938c96a50e995434b163c6f77c91bace9990R1146-R1155) leading to a regression. This PR fixes the `removeSubsCond` function, fixing the regression as a result. Closes #3162 Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 54da66a9996632315827ba37e14823de6405b4d9

PR #3166 removes the `BundleUnpacking` condition once resolution is successful. PR #3166 [modified an e2e test](operator-framework/operator-lifecycle-manager@54da66a#diff-11f70fc71ac22d725767916f562789de88d06eb9ebe19f337a59fd7035a3ca2dR2448) to reflect that change. However, the test being fixed in this PR is skipped for upstream, and runs only downstream.This PR is a follow up to #3166 to reflect the `BundleUnpacking` condition removal in the remaining test. Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 6e3f051a4d9ac32222a051029570b88c8ba9e4f6

openshift-ci-robot · 2024-02-05T20:31:09Z

@openshift-bot: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-05T20:31:15Z

@openshift-bot: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

stevekuznetsov · 2024-02-05T20:37:58Z

/retitle OCPBUGS-24587,OCPBUGS-28744: NO-ISSUE: Synchronize From Upstream Repositories

openshift-ci-robot · 2024-02-05T20:38:19Z

@openshift-bot: This pull request references Jira Issue OCPBUGS-24587, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Xia-Zhao-rh

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-28744, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

stevekuznetsov · 2024-02-05T20:38:36Z

/lgtm

anik120 · 2024-02-05T21:44:31Z

/retitle OCPBUGS-24587,OCPBUGS-28744: Synchronize From Upstream Repositories

openshift-ci · 2024-02-05T23:28:44Z

@openshift-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-olm-flaky	`249da52`	link	false	`/test e2e-gcp-olm-flaky`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-02-05T23:30:54Z

@openshift-bot: Jira Issue OCPBUGS-24587: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#679

Jira Issue OCPBUGS-24587 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-28744: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28744 has been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-02-06T01:56:54Z

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-registry-container-v4.16.0-202402060110.p0.g5748166.assembly.stream for distgit operator-registry.
All builds following this will include this PR.

openshift-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Feb 2, 2024

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 2, 2024

openshift-ci Bot requested a review from a team February 2, 2024 18:35

anik120 mentioned this pull request Feb 2, 2024

OCPBUGS-24587: Clear (existing) error cond from Subscription, once error resolved #680

Closed

openshift-ci Bot changed the title ~~NO-ISSUE: Synchronize From Upstream Repositories~~ OCPBUGS-28744: NO-ISSUE: Synchronize From Upstream Repositories Feb 2, 2024

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 2, 2024

openshift-ci Bot changed the title ~~OCPBUGS-28744: NO-ISSUE: Synchronize From Upstream Repositories~~ OCPBUGS-24587,OCPBUGS-28744: NO-ISSUE: Synchronize From Upstream Repositories Feb 2, 2024

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 2, 2024

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 2, 2024

openshift-ci Bot requested a review from jianzhangbjz February 2, 2024 19:23

anik120 reviewed Feb 2, 2024

View reviewed changes

openshift-ci Bot changed the title ~~OCPBUGS-24587,OCPBUGS-28744: NO-ISSUE: Synchronize From Upstream Repositories~~ OCPBUGS-24587,OCPBUGS-28744: Synchronize From Upstream Repositories Feb 2, 2024

openshift-bot changed the title ~~OCPBUGS-24587,OCPBUGS-28744: Synchronize From Upstream Repositories~~ NO-ISSUE: Synchronize From Upstream Repositories Feb 3, 2024

openshift-ci-robot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 3, 2024

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Feb 4, 2024

openshift-ci Bot changed the title ~~NO-ISSUE: Synchronize From Upstream Repositories~~ OCPBUGS-24587,OCPBUGS-28744: Synchronize From Upstream Repositories Feb 5, 2024

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 5, 2024

openshift-ci Bot requested a review from Xia-Zhao-rh February 5, 2024 14:55

dependabot Bot and others added 4 commits February 5, 2024 20:24

openshift-bot changed the title ~~OCPBUGS-24587,OCPBUGS-28744: Synchronize From Upstream Repositories~~ NO-ISSUE: Synchronize From Upstream Repositories Feb 5, 2024

openshift-bot force-pushed the synchronize-upstream branch from a788fc1 to 249da52 Compare February 5, 2024 20:31

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024

openshift-ci-robot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 5, 2024

openshift-ci Bot changed the title ~~NO-ISSUE: Synchronize From Upstream Repositories~~ OCPBUGS-24587,OCPBUGS-28744: NO-ISSUE: Synchronize From Upstream Repositories Feb 5, 2024

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 5, 2024

openshift-ci Bot assigned stevekuznetsov Feb 5, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024

openshift-ci Bot changed the title ~~OCPBUGS-24587,OCPBUGS-28744: NO-ISSUE: Synchronize From Upstream Repositories~~ OCPBUGS-24587,OCPBUGS-28744: Synchronize From Upstream Repositories Feb 5, 2024

openshift-merge-bot Bot merged commit 5748166 into openshift:master Feb 5, 2024

Uh oh!

Conversation

openshift-bot commented Feb 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 2, 2024

Uh oh!

openshift-ci Bot commented Feb 2, 2024

Uh oh!

openshift-ci Bot commented Feb 2, 2024

Uh oh!

openshift-ci Bot commented Feb 2, 2024

Uh oh!

stevekuznetsov commented Feb 2, 2024

Uh oh!

openshift-ci-robot commented Feb 2, 2024

Uh oh!

stevekuznetsov commented Feb 2, 2024

Uh oh!

openshift-ci-robot commented Feb 2, 2024

Uh oh!

stevekuznetsov commented Feb 2, 2024

Uh oh!

openshift-ci-robot commented Feb 2, 2024

Uh oh!

openshift-ci-robot commented Feb 2, 2024

Uh oh!

anik120 left a comment

Choose a reason for hiding this comment

Uh oh!

anik120 commented Feb 2, 2024

Uh oh!

openshift-ci-robot commented Feb 3, 2024

Uh oh!

Xia-Zhao-rh commented Feb 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rashmigottipati commented Feb 4, 2024

Uh oh!

stevekuznetsov commented Feb 5, 2024

Uh oh!

openshift-ci-robot commented Feb 5, 2024

Uh oh!

stevekuznetsov commented Feb 5, 2024

Uh oh!

openshift-ci-robot commented Feb 5, 2024

Uh oh!

openshift-ci-robot commented Feb 5, 2024

Uh oh!

stevekuznetsov commented Feb 5, 2024

Uh oh!

openshift-ci-robot commented Feb 5, 2024

Uh oh!

stevekuznetsov commented Feb 5, 2024

Uh oh!

anik120 commented Feb 5, 2024

Uh oh!

openshift-ci Bot commented Feb 5, 2024

Uh oh!

openshift-ci-robot commented Feb 5, 2024

Uh oh!

openshift-bot commented Feb 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

openshift-bot commented Feb 2, 2024 •

edited

Loading

Xia-Zhao-rh commented Feb 4, 2024 •

edited

Loading