OCPBUGS-46480: CVE-2024-12698 ose-olm-catalogd-container: incomplete fix for rapid reset (CVE-2023-39325/CVE-2023-44487) [openshift-4.18] by camilamacedo86 · Pull Request #101 · openshift/operator-framework-catalogd

camilamacedo86 · 2025-01-06T10:34:32Z

Cheery pick from https://github.com/operator-framework/catalogd

🐛 Disable HTTP/2 by Default for Webhooks to Mitigate CVE Risks operator-framework/catalogd#484
🐛 :nit: remove log saying that http is disabled operator-framework/catalogd#492

camilamacedo86 · 2025-01-06T10:34:57Z

tmshort · 2025-01-07T18:51:16Z

Because this is a backport, you need to change your commit headlines with:

UPSTREAM 484: Disable HTTP/2 by Default for Webhooks to Mitigate CVE Risks
UPSTREAM 492: remove log saying that http is disabled

The trailing (#xxx) can be removed, since the PR number is added in the UPSTREAM prefix

camilamacedo86 · 2025-01-09T21:15:33Z

/test okd-scos-e2e-aws-ovn

… Risks (#484) Ensure HTTP/2 is disabled by default for webhooks. Disabling HTTP/2 mitigates vulnerabilities associated with: - HTTP/2 Stream Cancellation (GHSA-qppj-fm5r-hxr3) - HTTP/2 Rapid Reset (GHSA-4374-p667-p6c8) While CVE fixes exist, they remain insufficient; disabling HTTP/2 helps reduce risks. For details, see: kubernetes/kubernetes#121197

tmshort

/lgtm

tmshort · 2025-01-10T18:57:27Z

/approve

openshift-ci · 2025-01-10T18:57:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-01-10T21:10:12Z

@camilamacedo86: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

camilamacedo86 · 2025-01-11T06:25:42Z

@joelanford @Xia-Zhao-rh I think we need labels you would add to complete it.
Could you please help us out?

Xia-Zhao-rh · 2025-01-13T03:01:11Z

/label cherry-pick-approved
/label qe-approved

Xia-Zhao-rh · 2025-01-13T03:16:03Z

/jira refresh

openshift-ci-robot · 2025-01-13T03:16:06Z

@Xia-Zhao-rh: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-01-13T03:54:24Z

@camilamacedo86: This pull request references Jira Issue OCPBUGS-46480, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-46480 to depend on a bug targeting a version in 4.19.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Cheery pick from https://github.com/operator-framework/catalogd

🐛 Disable HTTP/2 by Default for Webhooks to Mitigate CVE Risks operator-framework/catalogd#484

🐛 :nit: remove log saying that http is disabled operator-framework/catalogd#492

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

camilamacedo86 · 2025-01-13T03:54:30Z

/jira refresh

openshift-ci-robot · 2025-01-13T03:54:34Z

@camilamacedo86: This pull request references Jira Issue OCPBUGS-46480, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-46480 to depend on a bug targeting a version in 4.19.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

camilamacedo86 · 2025-01-13T03:55:14Z

/jira refresh

openshift-ci-robot · 2025-01-13T03:55:18Z

@camilamacedo86: This pull request references Jira Issue OCPBUGS-46480, which is invalid:

expected Jira Issue OCPBUGS-46480 to depend on a bug targeting a version in 4.19.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

camilamacedo86 · 2025-01-13T04:01:26Z

/jira refresh

openshift-ci-robot · 2025-01-13T04:01:30Z

@camilamacedo86: This pull request references Jira Issue OCPBUGS-46480, which is invalid:

expected Jira Issue OCPBUGS-46480 to depend on a bug targeting a version in 4.19.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

camilamacedo86 · 2025-01-13T04:07:33Z

/jira refresh

openshift-ci-robot · 2025-01-13T04:07:36Z

@camilamacedo86: This pull request references Jira Issue OCPBUGS-46480, which is invalid:

expected Jira Issue OCPBUGS-46480 to depend on a bug targeting a version in 4.19.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

camilamacedo86 · 2025-01-13T04:13:22Z

/jira refresh

openshift-ci-robot · 2025-01-13T04:13:27Z

@camilamacedo86: This pull request references Jira Issue OCPBUGS-46480, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-47473 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-47473 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
bug has dependents

Requesting review from QA contact:
/cc @Xia-Zhao-rh

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

camilamacedo86 · 2025-01-13T06:47:51Z

/label backport-risk-assessed

openshift-ci · 2025-01-13T06:48:00Z

@camilamacedo86: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

joelanford · 2025-01-13T14:40:34Z

/label backport-risk-assessed

openshift-ci-robot · 2025-01-13T14:45:34Z

@camilamacedo86: Jira Issue OCPBUGS-46480: All pull requests linked via external trackers have merged:

openshift/operator-framework-catalogd#101

Jira Issue OCPBUGS-46480 has been moved to the MODIFIED state.

Details

In response to this:

Cheery pick from https://github.com/operator-framework/catalogd

🐛 Disable HTTP/2 by Default for Webhooks to Mitigate CVE Risks operator-framework/catalogd#484

🐛 :nit: remove log saying that http is disabled operator-framework/catalogd#492

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2025-01-13T16:12:14Z

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-catalogd
This PR has been included in build ose-olm-catalogd-container-v4.18.0-202501131541.p0.g44050d1.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci Bot requested review from joelanford and oceanc80 January 6, 2025 10:35

camilamacedo86 force-pushed the fix-http-cve-4.18 branch from 783e10b to 980c7ff Compare January 9, 2025 17:31

camilamacedo86 added 2 commits January 10, 2025 18:45

UPSTREAM: 492: :nit: remove log saying that http is disabled (#492)

0a6c3a0

camilamacedo86 force-pushed the fix-http-cve-4.18 branch from 980c7ff to 0a6c3a0 Compare January 10, 2025 18:46

tmshort approved these changes Jan 10, 2025

View reviewed changes

openshift-ci Bot assigned tmshort Jan 10, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025

openshift-ci Bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Jan 13, 2025

openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jan 13, 2025

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 13, 2025

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 13, 2025

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 13, 2025

openshift-ci Bot requested a review from Xia-Zhao-rh January 13, 2025 04:13

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 13, 2025

openshift-ci Bot assigned bandrade, emmajiafan, jianzhangbjz, KeenonLee, kuiwang02 and Xia-Zhao-rh Jan 13, 2025

openshift-merge-bot Bot merged commit 44050d1 into openshift:release-4.18 Jan 13, 2025

camilamacedo86 deleted the fix-http-cve-4.18 branch January 13, 2025 19:16

Uh oh!

Conversation

camilamacedo86 commented Jan 6, 2025

Uh oh!

camilamacedo86 commented Jan 6, 2025

Uh oh!

tmshort commented Jan 7, 2025

Uh oh!

camilamacedo86 commented Jan 9, 2025

Uh oh!

tmshort left a comment

Choose a reason for hiding this comment

Uh oh!

tmshort commented Jan 10, 2025

Uh oh!

openshift-ci Bot commented Jan 10, 2025

Uh oh!

openshift-ci Bot commented Jan 10, 2025

Uh oh!

camilamacedo86 commented Jan 11, 2025

Uh oh!

Xia-Zhao-rh commented Jan 13, 2025

Uh oh!

Xia-Zhao-rh commented Jan 13, 2025

Uh oh!

openshift-ci-robot commented Jan 13, 2025

Uh oh!

openshift-ci-robot commented Jan 13, 2025

Uh oh!

camilamacedo86 commented Jan 13, 2025

Uh oh!

openshift-ci-robot commented Jan 13, 2025

Uh oh!

camilamacedo86 commented Jan 13, 2025

Uh oh!

openshift-ci-robot commented Jan 13, 2025

Uh oh!

camilamacedo86 commented Jan 13, 2025

Uh oh!

openshift-ci-robot commented Jan 13, 2025

Uh oh!

camilamacedo86 commented Jan 13, 2025

Uh oh!

openshift-ci-robot commented Jan 13, 2025

Uh oh!

camilamacedo86 commented Jan 13, 2025

Uh oh!

openshift-ci-robot commented Jan 13, 2025

Uh oh!

camilamacedo86 commented Jan 13, 2025

Uh oh!

openshift-ci Bot commented Jan 13, 2025

Uh oh!

joelanford commented Jan 13, 2025

Uh oh!

openshift-ci-robot commented Jan 13, 2025

Uh oh!

openshift-bot commented Jan 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants