Skip to content

BZ-1994420: Added a link to OCP Update Graph - #35600

Closed
sagidlow wants to merge 1 commit into
openshift:mainfrom
sagidlow:BZ-1994420
Closed

BZ-1994420: Added a link to OCP Update Graph#35600
sagidlow wants to merge 1 commit into
openshift:mainfrom
sagidlow:BZ-1994420

Conversation

@sagidlow

@sagidlow sagidlow commented Aug 18, 2021

Copy link
Copy Markdown
Contributor

Applies to 4.6+
BZ Link: https://bugzilla.redhat.com/show_bug.cgi?id=1994420
Preview Link: OpenShift Container Platform upgrade channels and releases. Scroll down to Upgrade version paths, and see the NOTE.
QE Ack needed.

@sagidlow sagidlow added this to the Next Release milestone Aug 18, 2021
@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 18, 2021
@sagidlow

Copy link
Copy Markdown
Contributor Author

Please review: @wking and @xltian

@netlify

netlify Bot commented Aug 18, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 6749530

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/611d4d869e313800083d1bfc

😎 Browse the preview: https://deploy-preview-35600--osdocs.netlify.app

@codyhoag
codyhoag self-requested a review August 18, 2021 18:18

@codyhoag codyhoag left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codyhoag codyhoag added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 18, 2021
@sagidlow

Copy link
Copy Markdown
Contributor Author

@xltian Please review this pending PR.

@wking

wking commented Aug 28, 2021

Copy link
Copy Markdown
Member

As I pointed out in the bug, I'd prefer pointing folks at in-cluster tools for this sort of thing, especially as cluster-specific things like openshift/enhancements#427 and openshift/enhancements#821 make relying on out-of-cluster summaries less useful. But this same language (with slightly different link bounds) is already over in the mirroring docs, so I'm 🤷 on including it here too.

@xltian

xltian commented Aug 30, 2021

Copy link
Copy Markdown

@jiajliu to review for QE.

@jiajliu

jiajliu commented Aug 30, 2021

Copy link
Copy Markdown

I also agreed with @wking. And QE don't refer to Red Hat Upgrade labs for the test.
Firstly, the link is not needed in most of upgrades(such as connected clusters), users can get suggested available update from both oc and web-console after selecting proper channel.
Secondly, for the disconnected cluster's upgrade, which users need decide the mirrored payloads. I think there is indeed some gaps, and we'd better to fix the gap through some in-cluster ways instead of a out-of-cluster tool, which may be not consistent with update service data all the time.
What's more, to be a temporary proposal, now the link is already included in the doc. So i think there is no need to included it here again, and maybe it will mislead all users to check the Red Hat Upgrade labs first even it already got the available update from upstream.

@sagidlow

Copy link
Copy Markdown
Contributor Author

Closing this PR as the comments provided by QE and SME leads me to believe this change is not needed. Closing BZ as WILLNOTFIX.

@sagidlow sagidlow closed this Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants