[OCPBUGS-104855]: Fix PPC example to use even CPU counts for HT compatibility - #117426
[OCPBUGS-104855]: Fix PPC example to use even CPU counts for HT compatibility#117426kquinn1204 wants to merge 3 commits into
Conversation
…bility The Performance Profile Creator example used --reserved-cpu-count=1 and --offlined-cpu-count=1, which fails on hyper-threading systems because CPUs must be allocated in even numbers per NUMA node. Change reserved count to 2 and remove offlined count to keep the 4-CPU example consistent (2 reserved + 2 isolated = 4 total). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@kquinn1204: This pull request references Jira Issue OCPBUGS-104855, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Thu Aug 06 15:38:16 - Prow CI generated the docs preview: |
|
@kquinn1204: No Jira issue is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The Performance Profile Creator changed its log output format from `level=info msg="..."` to `PPC: ...` starting in v4.20. Update both example output blocks (info and profile creation) to match the current format. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Apply the same corrections to the wrapper script procedure module (cnf-running-the-performance-creator-profile-offline.adoc): - Change --reserved-cpu-count from 1 to 2 for HT compatibility - Remove --offlined-cpu-count from example command and output - Update example output to v4.20+ PPC: log format - Update help output to show info as subcommand (v4.20+) - Update --info=log invocation to info subcommand syntax Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@kquinn1204: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s):
4.20, 4.21, 4.22
Issue:
https://redhat.atlassian.net/browse/OCPBUGS-104855
Link to docs preview:
QE review:
Additional information:
The Performance Profile Creator (PPC) example command used
--reserved-cpu-count=1and--offlined-cpu-count=1, which fails on hyper-threading systems (the default) with:Affected modules:
modules/cnf-running-the-performance-creator-profile.adoc(Podman procedure)modules/cnf-running-the-performance-creator-profile-offline.adoc(wrapper script procedure)Changes (both modules):
--reserved-cpu-countfrom1to2so the value is even and compatible with hyper-threading NUMA allocation.--offlined-cpu-countfrom the example entirely. On the existing 4-CPU example system,--reserved-cpu-count=2plus--offlined-cpu-count=2would consume all 4 CPUs, leaving zero for isolated workloads — an invalid configuration. The--offlined-cpu-countflag remains documented in the PPC argument reference table.reserved: "0-1",isolated: 2-3.level=info msg="..."log format to thePPC: ...format introduced in v4.20. Verified by testing PPC images from v4.19 (old format) through v4.22 (new format) — the cutover occurred in v4.20.--infoinvocation to reflect the v4.20+ subcommand syntax (infoinstead of--info=log).Cherry-pick guidance for backports:
The branch has 3 commits:
fc42ec6— CPU count fix only (retains oldlevel=info msg=format) — cherry-pick this for 4.19 and below0936dc0— Log format update for Podman module — relevant for 4.20+ onlydb62046— Same fixes for wrapper script module (CPU counts + log format + info subcommand) — relevant for 4.20+ only; for 4.19 and below, the wrapper script module needs only the CPU count fix with old format