OCPBUGS-56915: Add i18n for `AuthenticationErrorMessage` and `GrantErrorMessage` by logonoff · Pull Request #174 · openshift/oauth-server

logonoff · 2025-06-02T14:57:48Z

fixes https://issues.redhat.com/browse/OCPBUGS-56915

openshift-ci-robot · 2025-06-02T14:57:54Z

@logonoff: This pull request references Jira Issue OCPBUGS-56915, which is invalid:

expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

fixes https://issues.redhat.com/browse/OCPBUGS-56915

/assign @jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2025-06-02T15:05:54Z

/jira refresh

openshift-ci-robot · 2025-06-02T15:06:01Z

@logonoff: This pull request references Jira Issue OCPBUGS-56915, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.0) matches configured target version for branch (4.20.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jhadvig

/lgtm

logonoff

changes seem to work on a cluster

logonoff · 2025-06-02T19:00:16Z

/cherry-pick release-4.19 release-4.18

openshift-cherrypick-robot · 2025-06-02T19:00:19Z

@logonoff: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.19 release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ibihim · 2025-07-11T10:03:23Z

/retest-required

liouk · 2025-08-15T07:42:19Z

/lgtm

openshift-ci-robot · 2025-09-18T19:50:02Z

/retest-required

Remaining retests: 0 against base HEAD 8109879 and 2 for PR HEAD af181e2 in total

openshift-ci-robot · 2025-09-18T23:59:40Z

/retest-required

Remaining retests: 0 against base HEAD 8109879 and 2 for PR HEAD af181e2 in total

openshift-ci-robot · 2025-09-19T05:09:25Z

/retest-required

Remaining retests: 0 against base HEAD 8109879 and 2 for PR HEAD af181e2 in total

openshift-ci-robot · 2025-09-19T13:20:36Z

/retest-required

Remaining retests: 0 against base HEAD 8109879 and 2 for PR HEAD af181e2 in total

ibihim · 2025-09-30T05:53:47Z

/test e2e-aws-serial

openshift-ci-robot · 2025-10-20T20:10:14Z

/retest-required

Remaining retests: 0 against base HEAD 34b3502 and 1 for PR HEAD af181e2 in total

…rorMessage`

jhadvig

/lgtm

openshift-ci · 2025-10-22T14:26:33Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jhadvig, liouk, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

logonoff · 2025-10-22T17:40:33Z

/retest

logonoff · 2025-10-22T23:59:38Z

/retest

logonoff · 2025-10-23T04:11:23Z

/retest

logonoff · 2025-10-23T13:58:45Z

/retest

logonoff · 2025-10-23T19:38:50Z

/retest

logonoff · 2025-10-24T00:32:23Z

/retest

logonoff · 2025-10-24T04:45:09Z

/retest

logonoff · 2025-11-06T14:42:38Z

/retest

ibihim · 2025-12-01T10:27:37Z

/retest

logonoff · 2025-12-01T15:30:23Z

/verified by @logonoff

openshift-ci-robot · 2025-12-01T15:30:36Z

@logonoff: This PR has been marked as verified by @logonoff.

Details

In response to this:

/verified by @logonoff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-12-01T19:22:43Z

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-12-01T19:27:42Z

@logonoff: Jira Issue Verification Checks: Jira Issue OCPBUGS-56915
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-56915 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

fixes https://issues.redhat.com/browse/OCPBUGS-56915

/assign @jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2025-12-01T19:28:30Z

@logonoff: new pull request created: #203

Details

In response to this:

/cherry-pick release-4.19 release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot · 2025-12-08T20:45:09Z

Fix included in accepted release 4.21.0-0.nightly-2025-12-08-112148

openshift-ci Bot assigned jhadvig Jun 2, 2025

openshift-ci Bot requested review from ibihim and liouk June 2, 2025 14:58

logonoff changed the title ~~OCPBUGS-56915: Add i81n for AuthenticationErrorMessage~~ OCPBUGS-56915: Add i18n for AuthenticationErrorMessage Jun 2, 2025

logonoff changed the title ~~OCPBUGS-56915: Add i18n for AuthenticationErrorMessage~~ OCPBUGS-56915: Add i18n for AuthenticationErrorMessage and GrantErrorMessaged Jun 2, 2025

logonoff changed the title ~~OCPBUGS-56915: Add i18n for AuthenticationErrorMessage and GrantErrorMessaged~~ OCPBUGS-56915: Add i18n for AuthenticationErrorMessage and GrantErrorMessage Jun 2, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 2, 2025

openshift-ci Bot requested a review from yapei June 2, 2025 15:06

jhadvig approved these changes Jun 2, 2025

View reviewed changes

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2025

logonoff commented Jun 2, 2025

View reviewed changes

ibihim reviewed Jun 10, 2025

View reviewed changes

Comment thread pkg/server/errorpage/errorpage.go Outdated

ibihim reviewed Jun 10, 2025

View reviewed changes

Comment thread pkg/server/errorpage/errorpage.go Outdated

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2025

logonoff requested a review from ibihim June 10, 2025 11:53

openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 11, 2025

openshift-ci Bot assigned liouk Aug 15, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2025

OCPBUGS-56915: Add i18n for AuthenticationErrorMessage and `GrantEr…

1d68bbe

…rorMessage`

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Oct 21, 2025

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025

jhadvig approved these changes Oct 22, 2025

View reviewed changes

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 1, 2025

openshift-merge-bot Bot merged commit 3ab7450 into openshift:master Dec 1, 2025
10 checks passed

openshift-cherrypick-robot mentioned this pull request Dec 1, 2025

[release-4.19] OCPBUGS-66221: Add i18n for AuthenticationErrorMessage and GrantErrorMessage #203

Closed

Uh oh!

Conversation

logonoff commented Jun 2, 2025

Uh oh!

openshift-ci-robot commented Jun 2, 2025

Uh oh!

logonoff commented Jun 2, 2025

Uh oh!

openshift-ci-robot commented Jun 2, 2025

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

logonoff commented Jun 2, 2025

Uh oh!

openshift-cherrypick-robot commented Jun 2, 2025

Uh oh!

Uh oh!

Uh oh!

ibihim commented Jul 11, 2025

Uh oh!

liouk commented Aug 15, 2025

Uh oh!

openshift-ci-robot commented Sep 18, 2025

Uh oh!

openshift-ci-robot commented Sep 18, 2025

Uh oh!

openshift-ci-robot commented Sep 19, 2025

Uh oh!

openshift-ci-robot commented Sep 19, 2025

Uh oh!

ibihim commented Sep 30, 2025

Uh oh!

openshift-ci-robot commented Oct 20, 2025

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Oct 22, 2025

Uh oh!

logonoff commented Oct 22, 2025

Uh oh!

logonoff commented Oct 22, 2025

Uh oh!

logonoff commented Oct 23, 2025

Uh oh!

logonoff commented Oct 23, 2025

Uh oh!

logonoff commented Oct 23, 2025

Uh oh!

logonoff commented Oct 24, 2025

Uh oh!

logonoff commented Oct 24, 2025

Uh oh!

logonoff commented Nov 6, 2025

Uh oh!

ibihim commented Dec 1, 2025

Uh oh!

logonoff commented Dec 1, 2025

Uh oh!

openshift-ci-robot commented Dec 1, 2025

Uh oh!

openshift-ci Bot commented Dec 1, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 1, 2025

Uh oh!

openshift-cherrypick-robot commented Dec 1, 2025

Uh oh!

openshift-merge-robot commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development