WINC-2092: Add windows_exporter log collection

[jrvaldes]

Add windows_exporter/windows_exporter.log to the LOGS array in gather_windows_node_logs to collect windows_exporter service logs from Windows nodes.

follow-up to

• WINC-2046: Adds log file to windows-exporter windows-machine-config-operator#4355

Summary by CodeRabbit

• New Features
  • Added Windows Exporter logs to the Windows node log collection.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@jrvaldes: This pull request references WINC-2092 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Add windows_exporter/windows_exporter.log to the LOGS array in gather_windows_node_logs to collect windows_exporter service logs from Windows nodes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9986a271-96ce-4090-bdfa-49914d18f918

📥 Commits

Reviewing files that changed from the base of the PR and between fd47ab2 and 6a9bea4.

📒 Files selected for processing (1)

• collection-scripts/gather_windows_node_logs

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

The Windows node log collector now gathers windows_exporter/windows_exporter.log in addition to the existing Windows logs.

Changes

Windows node log collection

Layer / File(s)	Summary
Collect Windows exporter log collection-scripts/gather_windows_node_logs	The Windows log collection list includes windows_exporter/windows_exporter.log.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 6a9be

This localized change adds Windows exporter service logs to node diagnostics, with no actionable merge-blocking risk remaining after normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The only PR change adds a static log path to a Bash LOGS array; it introduces no Ginkgo test declarations or dynamic test names.
Test Structure And Quality	✅ Passed	The diff only adds a path to a Bash LOGS array; it changes no Ginkgo tests, assertions, cluster waits, setup, or cleanup.
Microshift Test Compatibility	✅ Passed	The PR changes only a Windows log-collection shell script by adding one log path; it adds no Ginkgo e2e tests or MicroShift-incompatible API usage.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only one Bash LOGS entry; it adds no Ginkgo e2e test, so SNO multi-node compatibility rules do not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff changes only a Windows log-collection script by adding one LOGS entry. It adds no deployment, controller, replica, affinity, topology, selector, or toleration scheduling constraint.
Ote Binary Stdout Contract	✅ Passed	The PR changes only a Windows log path in a Bash collection script; it does not add or modify an OTE binary or process-level suite stdout.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff adds one shell LOGS entry only. It adds no Ginkgo test and no IPv4 or external-network operation.
No-Weak-Crypto	✅ Passed	The only change adds a Windows exporter log path to LOGS; the diff introduces no cryptographic algorithm, custom crypto, or secret comparison.
Container-Privileges	✅ Passed	The PR adds only a LOGS entry for windows_exporter/windows_exporter.log; the diff introduces no privileged, host namespace, SYS_ADMIN, or escalation setting.
No-Sensitive-Data-In-Logs	✅ Passed	The diff adds only a fixed windows_exporter log path to an existing collector; it adds no credentials, tokens, PII, hostnames, or customer data to logging.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the addition of Windows Exporter log collection.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[mansikulkarni96]

/approve
/lgtm

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrvaldes, mansikulkarni96
Once this PR has been reviewed and has the lgtm label, please assign sferich888 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• collection-scripts/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jrvaldes]

/test e2e-aws

[jrvaldes]

/cc @ingvagabund @sferich888 PTAL

[openshift-ci]

@jrvaldes: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @ingvagabund @sferich888 PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@jrvaldes: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.