Skip to content

MCO-2424: Fix cert rotation timeout - #6309

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
HarshwardhanPatil07:fix-77784-cert-rotation-timeout
Jul 17, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
HarshwardhanPatil07:fix-77784-cert-rotation-timeout

Conversation

@HarshwardhanPatil07

Copy link
Copy Markdown
Member

In Failing runs, the controller took ~3m05s to rotate (the events fired 5 seconds after the 3m timeout)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 15, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 15, 2026 •

Copy link
Copy Markdown
Contributor

@HarshwardhanPatil07: This pull request references MCO-2424 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

In Failing runs, the controller took ~3m05s to rotate (the events fired 5 seconds after the 3m timeout)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@HarshwardhanPatil07, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 01694472-b330-43e2-b554-9f884cd15966

📥 Commits

Reviewing files that changed from the base of the PR and between 9d62fc7 and e824872.

📒 Files selected for processing (1)
  • test/extended-priv/secret.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci
openshift-ci Bot requested review from cheesesashimi and proietfb July 15, 2026 11:16
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2026
OCP-77784 has been failing in recent periodic runs because the
machine-config-controller takes slightly over 3 minutes to rotate
the machine-config-server-tls certificate. In the last 9 runs,
it failed 2 consecutive times with the rotation events arriving
~5 seconds after the 3m timeout. Increasing to 5m provides
sufficient headroom.

Signed-off-by: HarshwardhanPatil07 <harshpat@redhat.com>
@HarshwardhanPatil07
HarshwardhanPatil07 force-pushed the fix-77784-cert-rotation-timeout branch from bd782d4 to e824872 Compare July 15, 2026 11:20
@sergiordlr

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-ocl-part1
/test e2e-gcp-op-ocl-part2
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift

@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HarshwardhanPatil07, sergiordlr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [HarshwardhanPatil07,sergiordlr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HarshwardhanPatil07

Copy link
Copy Markdown
Member Author

/verified later by CI

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@HarshwardhanPatil07: Only users can be targets for the /verified later command.

Details

In response to this:

/verified later by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@HarshwardhanPatil07

Copy link
Copy Markdown
Member Author

/verified by @HarshwardhanPatil07

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 15, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@HarshwardhanPatil07: This PR has been marked as verified by @HarshwardhanPatil07.

Details

In response to this:

/verified by @HarshwardhanPatil07

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@HarshwardhanPatil07

Copy link
Copy Markdown
Member Author

/retest-required

@HarshwardhanPatil07

Copy link
Copy Markdown
Member Author

/test e2e-gcp-op-part1

1 similar comment
@HarshwardhanPatil07

Copy link
Copy Markdown
Member Author

/test e2e-gcp-op-part1

@isabella-janssen

Copy link
Copy Markdown
Member

/label acknowledge-critical-fixes-only

This only bumps a timeout in one of the MCO owned test suites, so there is no impact on functionality or risk to payloads.

@openshift-ci openshift-ci Bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jul 17, 2026
@isabella-janssen

Copy link
Copy Markdown
Member

/test unit

1 similar comment
@isabella-janssen

Copy link
Copy Markdown
Member

/test unit

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@HarshwardhanPatil07: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit cb061e1 into openshift:main Jul 17, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants