Skip to content

Add doc for IDMS and ITMS CRDs - #3530

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
QiWang19:crddocs
Feb 4, 2023
Merged

openshift-merge-robot merged 1 commit into
openshift:masterfrom
QiWang19:crddocs

Conversation

@QiWang19

@QiWang19 QiWang19 commented Feb 1, 2023

Copy link
Copy Markdown
Member

Signed-off-by: Qi Wang qiwan@redhat.com

- What I did
Follow up the PR: #3037
Add the document to give examples of the new mirror configuration CRDs ImageDigestMirrorSet and ImageTagMirrorSet.
- How to verify it

- Description for the changelog

Add document for ImageDigestMirrorSet and ImageTagMirrorSet.

@yuqi-zhang yuqi-zhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, thanks for the docs!

Some nits below:

Comment thread docs/ImageMirrorSetDesign.md Outdated
Comment thread docs/ImageMirrorSetDesign.md Outdated
Comment thread docs/ImageMirrorSetDesign.md Outdated
Comment thread docs/ImageMirrorSetDesign.md Outdated
@QiWang19
QiWang19 force-pushed the crddocs branch 2 times, most recently from ac85097 to d7101de Compare February 2, 2023 20:45
@QiWang19

QiWang19 commented Feb 2, 2023

Copy link
Copy Markdown
Member Author

@yuqi-zhang PTAL

@yuqi-zhang yuqi-zhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm, thanks! one last spelling change

Comment thread docs/ImageMirrorSetDesign.md Outdated
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2023
Follow up the PR: openshift#3037  Add the document to give examples of the
new mirror configuration CRDs ImageDigestMirrorSet and ImageTagMirrorSet.

Signed-off-by: Qi Wang <qiwan@redhat.com>
@QiWang19

QiWang19 commented Feb 3, 2023

Copy link
Copy Markdown
Member Author

@yuqi-zhang PTAL

@yuqi-zhang

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2023
@openshift-ci

openshift-ci Bot commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: QiWang19, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Feb 4, 2023

Copy link
Copy Markdown
Contributor

@QiWang19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn d26b594 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-gcp-ovn-upgrade d26b594 link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/e2e-hypershift d26b594 link false /test e2e-hypershift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
openshift-merge-robot merged commit ecc6bf3 into openshift:master Feb 4, 2023
ptalgulk01 pushed a commit to ptalgulk01/machine-config-operator that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants