Skip to content

CNTRLPLANE-3361: kms: add Slack discussion link to Vault resource requests numbers #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jun 3, 2026
Merged

CNTRLPLANE-3361: kms: add Slack discussion link to Vault resource requests numbers #2263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/operator/encryption/kms/pluginlifecycle/vault.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ func (v *vault) BuildSidecarContainer() (corev1.Container, error) {
TerminationMessagePolicy: corev1.TerminationMessageFallbackToLogsOnError,
// Vault team recommendation based on single-node OCP cluster measurements:
// ~10 mCPU / 32-64 MiB steady state, memory peaked at ~60 MiB under 400 KEK rotations.
// Slack discussion: https://redhat-external.slack.com/archives/C09KZ5QCBUH/p1779134070543079

@tjungblu tjungblu Jun 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I would appreciate the context, but this is a private channel with only us in it, so I'm not sure this will age so well....

@p0lyn0mial p0lyn0mial Jun 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the slack history is preserved so a redhater willing to learn more could visit that link and get more context, no ?

@tjungblu tjungblu Jun 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how would you be able to join the channel?

Resources: corev1.ResourceRequirements{
Requests: corev1.ResourceList{
corev1.ResourceMemory: resource.MustParse("64Mi"),
Expand Down