*: add support for platform none by crawford · Pull Request #982 · openshift/installer

crawford · 2019-01-03T00:46:42Z

This adds support for the "none" platform. This is used in situations
where the infrastructure will not be managed (bring-your-own).
Additionally, since the infrastructure is unmanaged, the installer
cannot create the infrastructure and the "cluster" target is therefore
invalid when used with the "none" platform. For this reason, the "none"
platform is hidden in the UX. It is still possible to use, but the
install-config will need an empty "none" object under platform.

cc @vrutkovs @wking @abhinavdahiya

vrutkovs · 2019-01-03T12:08:53Z

This produces correct config here, needs MCO to support that platform to have it working e2e

wking · 2019-01-03T19:20:04Z

/lgtm

openshift-bot · 2019-01-03T20:26:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

crawford · 2019-01-03T23:23:56Z

@wking I rebased onto master. There shouldn't be any code changes.

crawford · 2019-01-03T23:34:30Z

Slew of storage failures (https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/982/pull-ci-openshift-installer-master-e2e-aws/2537).

/retest

wking · 2019-01-03T23:35:43Z

/lgtm

The HostPath stuff should be addressed soon by either openshift/origin#21727 or openshift/origin#21724.

openshift-bot · 2019-01-04T00:28:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

crawford · 2019-01-04T00:36:52Z

Last failure:

time="2019-01-04T00:12:32Z" level=debug msg="Still waiting for the Kubernetes API: Get https://ci-op-p4xxcx5v-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443/version?timeout=32s: dial tcp 34.234.107.198:6443: connect: connection refused"
time="2019-01-04T00:13:05Z" level=debug msg="Still waiting for the Kubernetes API: Get https://ci-op-p4xxcx5v-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443/version?timeout=32s: dial tcp 54.144.109.157:6443: connect: connection refused"
time="2019-01-04T00:13:38Z" level=debug msg="Still waiting for the Kubernetes API: Get https://ci-op-p4xxcx5v-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443/version?timeout=32s: dial tcp 107.22.101.10:6443: connect: connection refused"
time="2019-01-04T00:14:13Z" level=debug msg="Still waiting for the Kubernetes API: Get https://ci-op-p4xxcx5v-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443/version?timeout=32s: dial tcp 107.22.101.10:6443: connect: connection refused"
time="2019-01-04T00:14:44Z" level=fatal msg="waiting for Kubernetes API: context deadline exceeded"

openshift-bot · 2019-01-04T02:29:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

crawford · 2019-01-04T03:19:34Z

Last failure:

time="2019-01-04T01:04:23Z" level=debug msg="Still waiting for the Kubernetes API: Get https://ci-op-p4xxcx5v-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443/version?timeout=32s: dial tcp 3.86.124.52:6443: connect: connection refused"
time="2019-01-04T01:04:55Z" level=debug msg="Still waiting for the Kubernetes API: Get https://ci-op-p4xxcx5v-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443/version?timeout=32s: dial tcp 52.0.78.37:6443: connect: connection refused"
time="2019-01-04T01:05:26Z" level=debug msg="Still waiting for the Kubernetes API: Get https://ci-op-p4xxcx5v-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443/version?timeout=32s: dial tcp 3.81.156.175:6443: connect: connection refused"
time="2019-01-04T01:05:58Z" level=debug msg="Still waiting for the Kubernetes API: Get https://ci-op-p4xxcx5v-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443/version?timeout=32s: dial tcp 3.81.156.175:6443: connect: connection refused"
time="2019-01-04T01:06:27Z" level=fatal msg="waiting for Kubernetes API: context deadline exceeded"

crawford · 2019-01-04T03:21:13Z

Last failure:

time="2019-01-04T03:13:12Z" level=debug msg="Still waiting for the Kubernetes API: Get https://ci-op-p4xxcx5v-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443/version?timeout=32s: dial tcp 52.202.58.63:6443: connect: connection refused"
time="2019-01-04T03:13:44Z" level=debug msg="Still waiting for the Kubernetes API: Get https://ci-op-p4xxcx5v-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443/version?timeout=32s: dial tcp 52.202.58.63:6443: connect: connection refused"
time="2019-01-04T03:14:15Z" level=debug msg="Still waiting for the Kubernetes API: Get https://ci-op-p4xxcx5v-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443/version?timeout=32s: dial tcp 52.202.58.63:6443: connect: connection refused"
time="2019-01-04T03:14:46Z" level=debug msg="Still waiting for the Kubernetes API: Get https://ci-op-p4xxcx5v-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443/version?timeout=32s: dial tcp 52.202.58.63:6443: connect: connection refused"
time="2019-01-04T03:14:58Z" level=fatal msg="waiting for Kubernetes API: context deadline exceeded"

That's three identical failures in a row... I could have sworn this code passed before.

crawford · 2019-01-04T03:22:35Z

I'm going to babysit this one and try to figure out what's going on...

/retest

crawford · 2019-01-04T03:37:32Z

Jan 04 03:36:41 ip-10-0-5-34 bootkube.sh[9504]: Pulling release image...
Jan 04 03:36:41 ip-10-0-5-34 bootkube.sh[9504]: Trying to pull registry.svc.ci.openshift.org/ci-op-p4xxcx5v/release:latest...Failed
Jan 04 03:36:41 ip-10-0-5-34 bootkube.sh[9504]: error pulling image "registry.svc.ci.openshift.org/ci-op-p4xxcx5v/release:latest": unable to pull registry.svc.ci.openshift.org/ci-op-p4xxcx5v/release:latest: unable to pull image: Error determining manifest MIME type for docker://registry.svc.ci.openshift.org/ci-op-p4xxcx5v/release:latest: Error reading manifest latest in registry.svc.ci.openshift.org/ci-op-p4xxcx5v/release: unauthorized: authentication required

Boo.

This adds support for the "none" platform. This is used in situations where the infrastructure will not be managed (bring-your-own). Additionally, since the infrastructure is unmanaged, the installer cannot create the infrastructure and the "cluster" target is therefore invalid when used with the "none" platform. For this reason, the "none" platform is hidden in the UX. It is still possible to use, but the install-config will need an empty "none" object under platform.

wking · 2019-01-04T04:37:43Z

The only thing that changed from f5d48a5 -> f350f2c was the commit date? Still

/lgtm

openshift-ci-robot · 2019-01-04T04:37:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [crawford,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

crawford · 2019-01-04T05:13:26Z

Clayton says he fixed something.

/retest

openshift-bot · 2019-01-04T06:31:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-01-04T08:32:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

vrutkovs · 2019-01-04T10:00:48Z

/retest

openshift-bot · 2019-01-04T10:33:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

vrutkovs · 2019-01-04T11:16:21Z

/retest

droslean · 2019-01-04T11:32:01Z

/test e2e-aws

vrutkovs · 2019-01-04T12:44:26Z

/retest

openshift-bot · 2019-01-04T14:35:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

vrutkovs · 2019-01-04T14:35:15Z

/retest

crawford · 2019-01-04T15:15:19Z

@vrutkovs do you know what has caused the recent failures?

crawford · 2019-01-04T15:16:53Z

The last one looks like a series of storage failures again.

vrutkovs · 2019-01-04T15:17:29Z

Seems openshift/origin#21727 should fix (some) storage issues

vrutkovs · 2019-01-04T16:02:43Z

/retest

openshift-ci-robot requested review from flaper87 and smarterclayton January 3, 2019 00:47

crawford changed the title ~~WIP: *: add support for platform none~~ *: add support for platform none Jan 3, 2019

wking reviewed Jan 3, 2019

View reviewed changes

Comment thread pkg/asset/cluster/cluster.go Outdated

Comment thread pkg/asset/cluster/cluster.go Outdated

Comment thread pkg/asset/installconfig/ssh.go Outdated

Comment thread pkg/types/validation/installconfig.go Outdated

Comment thread pkg/asset/machines/master.go Outdated

vrutkovs mentioned this pull request Jan 3, 2019

Support 'none' platform openshift/machine-config-operator#266

Merged

1 task

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 3, 2019

openshift-ci-robot assigned wking Jan 3, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2019

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2019

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2019

openshift-merge-robot merged commit 9a71042 into openshift:master Jan 4, 2019

crawford deleted the none branch January 4, 2019 17:45

vrutkovs mentioned this pull request Jan 4, 2019

openshift-ansible 4.0: set platform to 'none' instead of libvirt openshift/release#2504

Merged

wking mentioned this pull request Jan 4, 2019

pkg/types: Add cross-platform Networking.MachineCIDR #983

Merged

crawford mentioned this pull request Jan 4, 2019

Add an installer image for libvirt #978

Closed

vrutkovs mentioned this pull request Jan 8, 2019

Support "none" cloudprovider openshift/cluster-kube-controller-manager-operator#119

Merged

Uh oh!

Conversation

crawford commented Jan 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vrutkovs commented Jan 3, 2019

Uh oh!

wking commented Jan 3, 2019

Uh oh!

openshift-bot commented Jan 3, 2019

Uh oh!

crawford commented Jan 3, 2019

Uh oh!

crawford commented Jan 3, 2019

Uh oh!

wking commented Jan 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Jan 4, 2019

Uh oh!

crawford commented Jan 4, 2019

Uh oh!

openshift-bot commented Jan 4, 2019

Uh oh!

crawford commented Jan 4, 2019

Uh oh!

crawford commented Jan 4, 2019

Uh oh!

crawford commented Jan 4, 2019

Uh oh!

crawford commented Jan 4, 2019

Uh oh!

wking commented Jan 4, 2019

Uh oh!

openshift-ci-robot commented Jan 4, 2019

Uh oh!

crawford commented Jan 4, 2019

Uh oh!

openshift-bot commented Jan 4, 2019

Uh oh!

openshift-bot commented Jan 4, 2019

Uh oh!

vrutkovs commented Jan 4, 2019

Uh oh!

openshift-bot commented Jan 4, 2019

Uh oh!

vrutkovs commented Jan 4, 2019

Uh oh!

droslean commented Jan 4, 2019

Uh oh!

vrutkovs commented Jan 4, 2019

Uh oh!

openshift-bot commented Jan 4, 2019

Uh oh!

vrutkovs commented Jan 4, 2019

Uh oh!

crawford commented Jan 4, 2019

Uh oh!

crawford commented Jan 4, 2019

Uh oh!

vrutkovs commented Jan 4, 2019

Uh oh!

vrutkovs commented Jan 4, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

crawford commented Jan 3, 2019 •

edited

Loading

wking commented Jan 3, 2019 •

edited

Loading