Skip to content

OpenStack: Image name validations - #2492

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
Fedosin:image_name_validations
Oct 22, 2019
Merged

OpenStack: Image name validations#2492
openshift-merge-robot merged 1 commit into
openshift:masterfrom
Fedosin:image_name_validations

Conversation

@Fedosin

@Fedosin Fedosin commented Oct 10, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

When the image is provided by user, i.e. not created automatically by the installer, we need to check that the image exists and there are no other images with this name.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2019
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 10, 2019
@Fedosin
Fedosin force-pushed the image_name_validations branch from 8da7fdf to 237ac4b Compare October 16, 2019 10:18
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 16, 2019
@Fedosin Fedosin changed the title WIP: OpenStack: Image name validations OpenStack: Image name validations Oct 16, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2019
@Fedosin

Fedosin commented Oct 16, 2019

Copy link
Copy Markdown
Contributor Author

/hold cancel

@Fedosin
Fedosin force-pushed the image_name_validations branch from 237ac4b to 126d03c Compare October 16, 2019 10:44
@Fedosin

Fedosin commented Oct 16, 2019

Copy link
Copy Markdown
Contributor Author

/retest

@jstuever

jstuever commented Oct 17, 2019

Copy link
Copy Markdown
Contributor

/label platform/openstack
/cc @mandre @tomassedovic
/uncc @jstuever

@openshift-ci-robot

openshift-ci-robot commented Oct 17, 2019

Copy link
Copy Markdown
Contributor

@jstuever: The label(s) /label platform/openstack cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga

Details

In response to this:

/label platform/openstack
/cc @mandre @tomassedovic
/uncc @jstuever

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
openshift-ci-robot requested review from mandre and tomassedovic and removed request for jstuever October 17, 2019 19:41
@mandre

mandre commented Oct 18, 2019

Copy link
Copy Markdown
Member

/label platform/openstack

@mandre

mandre commented Oct 18, 2019

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2019
abhinavdahiya
abhinavdahiya reviewed Oct 21, 2019
View reviewed changes
Comment thread pkg/rhcos/openstack.go Outdated

@abhinavdahiya abhinavdahiya Oct 21, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move this to pkg/tfvars/openstack, that seems like the best place for this.

Also would like to recommend this be private function and not part of the package API

@Fedosin Fedosin Oct 22, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! done

@Fedosin
OpenStack: validate overridden image names
a165e24 
If the user provides an overridden Glance image name then we need to
validate that this image exists and there are no other images with
this name.
@Fedosin
Fedosin force-pushed the image_name_validations branch from 126d03c to a165e24 Compare October 22, 2019 09:22
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Oct 22, 2019
@Fedosin

Fedosin commented Oct 22, 2019

Copy link
Copy Markdown
Contributor Author

/test e2e-aws

@mandre

mandre commented Oct 22, 2019

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2019
@openshift-ci-robot

openshift-ci-robot commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot

openshift-bot commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
openshift-merge-robot merged commit afb88e5 into openshift:master Oct 22, 2019
@Fedosin
Fedosin deleted the image_name_validations branch November 1, 2019 11:17
@Fedosin Fedosin mentioned this pull request Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74
@mandre mandre Awaiting requested review from mandre
@tomassedovic tomassedovic Awaiting requested review from tomassedovic
1 more reviewer
@abhinavdahiya abhinavdahiya abhinavdahiya left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mandre mandre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/openstack size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Fedosin @jstuever @openshift-ci-robot @mandre @openshift-bot @abhinavdahiya @openshift-merge-robot