libvirt install: use fqdn for libvirt instance names

[michaelgugino]

[root@mguginop50 ~]# virsh list
 Id    Name                           State
----------------------------------------------------
 1     master0                        running
 2     bootstrap                      running
 3     worker-sdb9x                   running

This output should match resolvable fqdn of the cluster. Would make cleaning up / managing easier.

[wking]

Would make cleaning up / managing easier.

We have stubs for libvirt cleanup from #324 that use prefixes. Thoughts on that approach?

[michaelgugino]

@wking I'm not worried about deprovisioning as a function of the installer, I'm concerned with good house-keeping and sensible naming of the libvirt instances. It doesn't make any sense to call a machine 'master0' in libvirt and then name it <cluster-name>-master-0.tt.testing everywhere else.

[wking]

It doesn't make any sense to call a machine 'master0' in libvirt and then name it <cluster-name>-master-0.tt.testing everywhere else.

With #660, master nodes will be named {cluster-name}-master-{count}, which matches the hostname portion of their domain names. I don't think we need the base-domain suffix, because we're already requiring a unique-to-that-libvirt cluster name. Does that sound good to you?

[michaelgugino]

@wking sounds good, thanks!