openshift-install may be ignoring region chosen for install config

[dgoodwin]

Testing openshift-install in a container this morning, I started getting an error like:

bash-4.2# openshift-install cluster
? Email Address dgoodwin@redhat.com
? Password [? for help] ********
? SSH Public Key <none>
? Base Domain REDACTED
? Cluster Name dgoodwin1
? Pull Secret REDACTED
? Platform aws
? Region us-east-1 (N. Virginia)
FATA[0046] failed to generate asset: failed to determine default AMI: MissingRegion: could not find region configuration 

I made a guess that it was ignoring what I selected and instead looking for ~/.aws/config which contains a default region to use. When I ran my container with "-v /home/dgoodwin/.aws/config:/home/user/.aws/config:Z" this particular error went away, leading me to believe it may not properly be loading the region from the install config that gets generated.

Guess would be that Terraform is not loading AWS creds the same way as the installer.

[dgoodwin]

CC @ironcladlou as I think this might be related to what you were seeing as well.

[ironcladlou]

I noticed this last night on my new machine; I had forgotten to create ~/.aws/config with region settings for my profile; doing so fixed it.

[wking]

Fixed by #346.