libvirt installer leaves lots of artifacts when failing

[michaelgugino]

Error: Error applying plan:

3 error(s) occurred:

• libvirt_volume.master: 1 error(s) occurred:

• libvirt_volume.master: storage volume 'master0' already exists

• libvirt_network.tectonic_net: 1 error(s) occurred:

• libvirt_network.tectonic_net: Error updating autostart for network: virError(Code=55, Domain=19, Message='Requested operation is not valid: cannot set autostart for transient network')

• module.bootstrap.libvirt_volume.bootstrap: 1 error(s) occurred:

• libvirt_volume.bootstrap: storage volume 'bootstrap' already exists

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

I clean up some stuff, then re-run, then it complains about other stuff already existing, rinse, repeat.

[wking]

First, what version of the installer are you running? We really need to add a --version with at least the Git hash... Do you have #321? How did you invoke the cleanup? Did it give you any error messages then?

I clean up some stuff

There's virsh-cleanup.sh if you are ok blowing away all things libvirt. And #324 has WIP on more targetted libvirt cleanup with the next-gen openshift-install command (although we've disabled the libvirt portion there while we sort out its CGO requirement).

[michaelgugino]

I was using tip of master branch. I came up with my own cleanup script.

I suppose the point I'm trying to make is that the installer is not very flexible if you hit an error, you have to manually delete all the things it created before trying again, and it doesn't present you with any list of what it did or tell you where to find the terraform manifests or otherwise how to continue.

[wking]

I'm going to close this now that #387 has landed a destroy-cluster implementation for libvirt. Feel free to continue discussing here or in a new issue if that is not covering your use-case.