baremetal: Need additional validation on apiVIP and ingressVIP

[russellb]

Original issue from @stbenjam - openshift-metal3/kni-installer#142

Currently we just validate that it's a valid IP, but we should check that it is also not part of the MachineCIDR / ClusterNetwork / Sevice Network

See: #1873 (comment)

[bcrochet]

/assign

[tomassedovic]

@bcrochet I've just implemented this for OpenStack:

ade37f5

[tomassedovic]

oh nevermind I didn't see you've added a commit already

[bcrochet]

oh nevermind I didn't see you've added a commit already

I'm taking some of what you have too... :)

[bcrochet]

@russellb @stbenjam For clarification... The VIPs should be in MachineCIDR, but should not be in ClusterNetwork and Service Network. Correct?

[russellb]

@russellb @stbenjam For clarification... The VIPs should be in MachineCIDR, but should not be in ClusterNetwork and Service Network. Correct?

sounds right

[bcrochet]

As noted in the patch that fixes this, the MachineCIDR is already checked for overlap of Cluster network and Service network. So, as long as VIP is in MachineCIDR, it cannot be in the other two.