Skip to content

Updating openshift-enterprise-base-rhel9-container image to be consistent with ART for 5.1 - #251

Open
openshift-bot wants to merge 1 commit into
openshift:masterfrom
openshift-bot:art-consistency-openshift-5.1-openshift-enterprise-base-rhel9
Open

openshift-bot wants to merge 1 commit into
openshift:masterfrom
openshift-bot:art-consistency-openshift-5.1-openshift-enterprise-base-rhel9

Conversation

@openshift-bot

@openshift-bot openshift-bot commented Aug 15, 2026 •

Copy link
Copy Markdown
Contributor

Updating openshift-enterprise-base-rhel9-container image to be consistent with ART for 5.1
TLDR:
Product builds by ART can be configured for different base and builder images than corresponding CI
builds. This automated PR requests a change to CI configuration to align with ART's configuration;
please take steps to merge it quickly or contact ART to coordinate changes.

The configuration in the following ART component metadata is driving this alignment request:
openshift-enterprise-base-rhel9.yml.

Detail:

This repository is out of sync with the downstream product builds for this component. The CI
configuration for at least one image differs from ART's expected product configuration. This should
be addressed to ensure that the component's CI testing accurate reflects what customers will
experience.

Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a
different version, usually prior to GA. The intent is to effect changes in both configurations
simultaneously without breaking either CI or ART builds, so usually ART builds are configured to
consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may
also configure changes in GA releases with CI remaining canonical for a brief grace period to enable
CI to succeed and the alignment PR to merge. In either case, ART configuration will be made
canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is
important to align CI configuration as soon as possible.

PRs are also triggered when CI configuration changes without ART coordination, for instance to
change the number of builder images or to use a different golang version. These changes should be
coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated
first to enable the changes to occur simultaneously in both CI and ART at the same time. This also
gives ART a chance to validate the intended changes first. For instance, ART compiles most
components with the Golang version being used by the control plane for a given OpenShift release.
Exceptions to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift staff engineers and
communicated to the ART team.

Roles & Responsibilities:

  • Component owners are responsible for ensuring these alignment PRs merge with passing
    tests OR that necessary metadata changes are reported to the ART team
    in #forum-ocp-art on Slack. If necessary, the changes required by this pull request can be
    introduced with a separate PR opened by the component team. Once the repository is aligned,
    this PR will be closed automatically.
  • In particular, it could be that a job like verify-deps is complaining. In that case, please open
    a new PR with the dependency issues addressed (and base images bumped). ART-9595 for reference.
  • Patch-manager or those with sufficient privileges within this repository may add
    any required labels to ensure the PR merges once tests are passing. In cases where ART config is
    canonical, downstream builds are already being built with these changes, and merging this PR
    only improves the fidelity of our CI. In cases where ART config is not canonical, this provides
    a grace period for the component team to align their CI with ART's configuration before it becomes
    canonical in product builds.

Change behavior of future PRs:

  • In case you just want to follow the base images that ART suggests, you can configure additional labels to be
    set up automatically. This means that such a PR would merge without human intervention (and awareness!) in the future.
    To do so, open a PR to set the auto_label attribute in the image configuration. Example
  • You can set a commit prefix, like UPSTREAM: <carry>: . An example.

If you have any questions about this pull request, please reach out in the #forum-ocp-art Slack channel.

@openshift-bot

Copy link
Copy Markdown
Contributor Author

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-bot openshift-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. verified Signifies that the PR passed pre-merge verification criteria labels Aug 15, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws
/test e2e-aws-upgrade
/test e2e-metal-ipi-ovn-ipv6

@coderabbitai

coderabbitai Bot commented Aug 15, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a3ce9ced-f544-45d5-8d7f-0f395cc6485d

📥 Commits

Reviewing files that changed from the base of the PR and between 3293057 and 741acdc.

📒 Files selected for processing (1)
  • base/Dockerfile.rhel9

Walkthrough

The RHEL 9 Dockerfile now uses ocp/5.1:base-rhel9 in both builder and final stages. Existing PQ crypto-policy handling and configuration copying remain unchanged.

Changes

RHEL 9 base image

Layer / File(s) Summary
Update base image reference
base/Dockerfile.rhel9
Both Docker build stages now use ocp/5.1:base-rhel9 instead of ocp/5.0:base-rhel9.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • openshift/images#250: Updates the base image from OpenShift 5.0 to 5.1 in corresponding RHEL Dockerfiles.
  • openshift/images#229: Updates the base/Dockerfile.rhel9 base image reference to align with ART configuration.
  • openshift/images#236: Modifies builder and final base image references in base/Dockerfile.rhel9.

Suggested reviewers: sdodson

Merge Risk: 🔵 Low · up to 741ac

The PR changes the container base image, so inherited runtime user, health-check behavior, and required package and crypto-policy tooling must remain compatible. It is mergeable with explicit owner confirmation of these bounded compatibility and security/operability contracts; no blocking failure is supplied.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only two Dockerfile FROM references. No Ginkgo test title or test file changed, so no unstable test name was introduced.
Test Structure And Quality ✅ Passed The PR changes only two Dockerfile base-image references; the diff contains no Go or Ginkgo test code, so the stated test-quality requirements do not apply.
Microshift Test Compatibility ✅ Passed The pull request changes only two Dockerfile base-image references; it adds no Ginkgo e2e tests or MicroShift-incompatible test behavior.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only two Dockerfile base-image references from 5.0 to 5.1. It adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The diff changes only two Dockerfile base-image references; it adds no deployment manifest, operator/controller code, or topology-related scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The commit changes only two Dockerfile base-image references; it adds no OTE binary code or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only two Dockerfile base-image references; it adds no Ginkgo tests or new IPv4 assumptions or external connectivity requirements.
No-Weak-Crypto ✅ Passed The PR only changes base image tags from 5.0 to 5.1; the changed lines contain no listed weak algorithms, crypto implementations, or secret comparisons.
Container-Privileges ✅ Passed The diff only changes the two base-image references from 5.0 to 5.1; it adds no privileged, host namespace, SYS_ADMIN, allowPrivilegeEscalation, or root directives.
No-Sensitive-Data-In-Logs ✅ Passed The diff only changes two base-image references; it adds no logging or sensitive-data output. Existing echo commands write fixed yum settings.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the update from the OpenShift 5.0 base image to the ART-aligned OpenShift 5.1 base image.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jupierce and sdodson August 15, 2026 06:03
@openshift-ci

openshift-ci Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci

openshift-ci Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

@openshift-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants