CNTRLPLANE-3604: Add CAPI migration flag placeholder - #9145
Conversation
To introduce the CAPI migration feature, first we need to add the opt-out flag in order to activate it before the migration feature is merged. Signed-off-by: Borja Clemente <bclement@redhat.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
📝 WalkthroughWalkthroughThe install command adds a Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Skipping CI for Draft Pull Request. |
|
/area cli |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9145 +/- ##
=======================================
Coverage 44.61% 44.61%
=======================================
Files 774 774
Lines 97098 97099 +1
=======================================
+ Hits 43317 43318 +1
Misses 50785 50785
Partials 2996 2996
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Scheduling tests matching the |
|
/verified by @csrwng Built and ran |
|
@csrwng: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
celebdor
left a comment
There was a problem hiding this comment.
/lgtm
Thanks! This will do
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: celebdor, clebs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/override "ci/prow/e2e-kubevirt-aws-ovn-reduced" |
|
@celebdor: Overrode contexts on behalf of celebdor: ci/prow/e2e-kubevirt-aws-ovn-reduced DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Test Resultse2e-aws
e2e-aks
|
|
/retitle CNTRLPLANE-3604: Add CAPI migration flag placeholder |
|
@clebs: This pull request references CNTRLPLANE-3604 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@celebdor: This pull request references CNTRLPLANE-3604 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override "ci/prow/e2e-azure-v2-self-managed" |
|
@celebdor: Overrode contexts on behalf of celebdor: ci/prow/e2e-azure-v2-self-managed DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@clebs: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
#8938 introduces the CAPI storage version migration including an opt-out flag. To introduce the feature safely, we need to add the opt-out flag in order to enable the opt-out in relevant places before the migration feature is merged.
This avoids accidental migrations on our envs.
Special notes for your reviewer:
Checklist:
Summary by CodeRabbit
--disable-capi-migrationoption to the install command.