Skip to content

CNTRLPLANE-3604: Add CAPI migration flag placeholder - #9145

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
clebs:migration-placeholder
Jul 29, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
clebs:migration-placeholder

Conversation

@clebs

@clebs clebs commented Jul 28, 2026 •

Copy link
Copy Markdown
Member

What this PR does / why we need it:

#8938 introduces the CAPI storage version migration including an opt-out flag. To introduce the feature safely, we need to add the opt-out flag in order to enable the opt-out in relevant places before the migration feature is merged.

This avoids accidental migrations on our envs.

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Summary by CodeRabbit

  • New Features
    • Added a --disable-capi-migration option to the install command.
    • The option is currently reserved for future functionality.

To introduce the CAPI migration feature, first we need to add the
opt-out flag in order to activate it before the migration feature is
merged.

Signed-off-by: Borja Clemente <bclement@redhat.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2026
@coderabbitai

coderabbitai Bot commented Jul 28, 2026 •

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The install command adds a DisableCAPIMigration boolean option and exposes it through the persistent --disable-capi-migration flag. The flag is documented as a placeholder, and no installation logic consumes the option in this change.

Suggested reviewers: bryan-cox, csrwng

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only adds a flag/field in cmd/install/install.go; no test files or Ginkgo titles were changed.
Test Structure And Quality ✅ Passed No Ginkgo tests were added or modified; the PR only adds a CLI flag in cmd/install/install.go, so this test-quality check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only adds a new install CLI flag and Options field; no manifests, controllers, replicas, or scheduling constraints were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only cmd/install/install.go changed, adding a CLI flag; no new Ginkgo e2e tests or networking assumptions were introduced.
No-Weak-Crypto ✅ Passed Only a new boolean flag/CLI option was added in cmd/install; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear in the touched code.
Container-Privileges ✅ Passed Only cmd/install/install.go changed; no privileged/container security settings or manifests were modified.
No-Sensitive-Data-In-Logs ✅ Passed PR only adds a new boolean option and CLI flag; no new logging calls or sensitive data fields are introduced in cmd/install/install.go.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding a placeholder CAPI migration opt-out flag.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@clebs

clebs commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

/area cli

@openshift-ci openshift-ci Bot added the area/cli Indicates the PR includes changes for CLI label Jul 28, 2026
@codecov

codecov Bot commented Jul 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.61%. Comparing base (76220f1) to head (64e29e7).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9145   +/-   ##
=======================================
  Coverage   44.61%   44.61%           
=======================================
  Files         774      774           
  Lines       97098    97099    +1     
=======================================
+ Hits        43317    43318    +1     
  Misses      50785    50785           
  Partials     2996     2996           
Files with missing lines Coverage Δ
cmd/install/install.go 68.91% <100.00%> (+0.02%) ⬆️
Flag Coverage Δ
cmd-support 38.39% <100.00%> (+<0.01%) ⬆️
cpo-hostedcontrolplane 47.22% <ø> (ø)
cpo-other 45.25% <ø> (ø)
hypershift-operator 54.55% <ø> (ø)
other 33.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clebs
clebs marked this pull request as ready for review July 28, 2026 16:16
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2026
@openshift-ci
openshift-ci Bot requested review from jparrill and muraee July 28, 2026 16:24
@csrwng csrwng added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jul 28, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-azure-v2-self-managed
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws
/test e2e-v2-gke
/test unit
/test verify

@csrwng

csrwng commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

/verified by @csrwng

Built and ran hypershift install --disable-capi-migration to make sure that no errors are thrown.
Ran hypershift install --disable-capi-migration-blah to verify that I indeed get an error with an unknown flag.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 28, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@csrwng: This PR has been marked as verified by @csrwng.

Details

In response to this:

/verified by @csrwng

Built and ran hypershift install --disable-capi-migration to make sure that no errors are thrown.
Ran hypershift install --disable-capi-migration-blah to verify that I indeed get an error with an unknown flag.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@celebdor celebdor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks! This will do

@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: celebdor, clebs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@celebdor

Copy link
Copy Markdown
Collaborator

/override "ci/prow/e2e-kubevirt-aws-ovn-reduced"

@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@celebdor: Overrode contexts on behalf of celebdor: ci/prow/e2e-kubevirt-aws-ovn-reduced

Details

In response to this:

/override "ci/prow/e2e-kubevirt-aws-ovn-reduced"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cwbotbot

cwbotbot commented Jul 28, 2026 •

Copy link
Copy Markdown

Test Results

e2e-aws

e2e-aks

@celebdor

celebdor commented Jul 29, 2026 •

Copy link
Copy Markdown
Collaborator

/retitle CNTRLPLANE-3604: Add CAPI migration flag placeholder

@openshift-ci openshift-ci Bot changed the title CNTRLPLANE-3604 feat(placeholder): Add CAPI migration flag placeholder CNTRLPLANE-3604: Add CAPI migration flag placeholder Jul 29, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 29, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 29, 2026 •

Copy link
Copy Markdown

@clebs: This pull request references CNTRLPLANE-3604 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

#8938 introduces the CAPI storage version migration including an opt-out flag. To introduce the feature safely, we need to add the opt-out flag in order to enable the opt-out in relevant places before the migration feature is merged.

This avoids accidental migrations on our envs.

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Summary by CodeRabbit

  • New Features
  • Added a --disable-capi-migration option to the install command.
  • The option is currently reserved for future functionality.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@celebdor

Copy link
Copy Markdown
Collaborator

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Jul 29, 2026 •

Copy link
Copy Markdown

@celebdor: This pull request references CNTRLPLANE-3604 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@celebdor

Copy link
Copy Markdown
Collaborator

/override "ci/prow/e2e-azure-v2-self-managed"

@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@celebdor: Overrode contexts on behalf of celebdor: ci/prow/e2e-azure-v2-self-managed

Details

In response to this:

/override "ci/prow/e2e-azure-v2-self-managed"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@clebs: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit f1dafc1 into openshift:main Jul 29, 2026
41 checks passed
@clebs
clebs deleted the migration-placeholder branch July 29, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants