Skip to content

NO-JIRA: drop redundant api_ux_validation e2e test - #8209

Closed
enxebre wants to merge 1 commit into
mainfrom
drop-api-ux-validation-e2e
Closed

enxebre wants to merge 1 commit into
mainfrom
drop-api-ux-validation-e2e

Conversation

@enxebre

@enxebre enxebre commented Apr 13, 2026 •

Copy link
Copy Markdown
Member

Summary

Test plan

  • make test passes (envtest suites continue to validate all CRD CEL rules)
  • make verify passes
  • No other test files depend on the removed assets

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed internal API validation test suite and associated test assets.

NO-JIRA

The envtest suites introduced in PR #8089 cover the same CEL and
schema validations exercised by this E2E test. The envtest approach
runs against a lightweight API server during `make test` without
requiring a live management cluster, making it faster and more
reliable.

Remove the E2E test file and its dedicated base assets since they
are now fully superseded by the declarative envtest test suites in
cmd/install/assets/crds/hypershift-operator/tests/.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 13, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@enxebre: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

Test plan

  • make test passes (envtest suites continue to validate all CRD CEL rules)
  • make verify passes
  • No other test files depend on the removed assets

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Apr 13, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 17b2e387-5650-4c09-8b1f-8e582ca8e6d6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This pull request removes an end-to-end test suite and its associated test assets. The api_ux_validation_test.go file containing the "API UX Validation" test suite was deleted entirely, along with its helper functions testHostedClusterCreation and testNodePoolCreation. Additionally, two Kubernetes manifest files used as test assets—hostedcluster-base.yaml and nodepool-base.yaml—were removed. These assets defined base HostedCluster and NodePool resource configurations for the validation tests. The removal eliminates validation scenarios for both HostedCluster and NodePool resources across multiple platform configurations and constraint validations.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch drop-api-ux-validation-e2e

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2026
@enxebre enxebre closed this Apr 13, 2026
@openshift-ci
openshift-ci Bot requested review from devguyio and jparrill April 13, 2026 08:50
@openshift-ci openshift-ci Bot added area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Apr 13, 2026
@enxebre
enxebre deleted the drop-api-ux-validation-e2e branch April 13, 2026 08:50
@codecov

codecov Bot commented Apr 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.63%. Comparing base (783f795) to head (4d904c8).
⚠️ Report is 71 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8209   +/-   ##
=======================================
  Coverage   34.63%   34.63%           
=======================================
  Files         767      767           
  Lines       93186    93186           
=======================================
  Hits        32277    32277           
  Misses      58236    58236           
  Partials     2673     2673           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants