Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR openshift#8089 copied feature gate YAML files from api/ to install assets, but the copies were made before PR openshift#7774 added ExternalOIDCWithUpstreamParity to the source files. Regenerate the copies via `make api`. Also make `git update-index --refresh` non-fatal in the Verify workflow, since it can return non-zero on timestamp-only changes even when content is identical. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
24c8223 to
10ec53e
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/close |
|
@bryan-cox: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
git update-index --refreshreturns non-zero when file timestamps differ from the index, even when file content is unchanged-e(default in GitHub Actions), the Verify step fails immediately on that line before reaching the actual content diff checksgit update-index --refreshsince the subsequentgit diff-files,git diff-index, andgit diff --exit-codecommands perform the real content verificationTest plan
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Summary by CodeRabbit
Release Notes
This release contains no user-visible changes. The update includes internal workflow improvements to enhance the reliability of our continuous integration process.