Skip to content

[release-4.15] OCPBUGS-32404: Fix failure to create a second hostedcluster in the same namespace - #3907

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.15from
muraee:fix-empty-infraid-rel-4.15
Jun 19, 2024
Merged

[release-4.15] OCPBUGS-32404: Fix failure to create a second hostedcluster in the same namespace#3907
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.15from
muraee:fix-empty-infraid-rel-4.15

Conversation

@muraee

@muraee muraee commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

manual cherry-pick of #3900

@muraee
move reconcileCLISecrets after infraID is defaulted
37ab8e5 
- if reconcileCLISecrets is executed before spec.infraID is set, it might list secrets not belonging to this cluster and fail to set ownerReference.
@muraee muraee changed the title move reconcileCLISecrets after infraID is defaulted OCPBUGS-32404: Fix failure to create a second hostedcluster in the same namespace Apr 18, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 18, 2024
@openshift-ci-robot

openshift-ci-robot commented Apr 18, 2024

Copy link
Copy Markdown

@muraee: This pull request references Jira Issue OCPBUGS-32404, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-32404 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

manual cherry-pick of #3900

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from hasueki and sjenning April 18, 2024 09:26
@openshift-ci openshift-ci Bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label Apr 18, 2024
@openshift-ci

openshift-ci Bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Apr 18, 2024
@muraee

muraee commented Apr 18, 2024

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Apr 18, 2024

Copy link
Copy Markdown

@muraee: This pull request references Jira Issue OCPBUGS-32404, which is invalid:

  • expected dependent Jira Issue OCPBUGS-32228 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@muraee

muraee commented Apr 23, 2024

Copy link
Copy Markdown
Contributor Author

/retest-required

@stevekuznetsov

stevekuznetsov commented Apr 29, 2024

Copy link
Copy Markdown
Contributor

/lgtm
/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Apr 29, 2024

Copy link
Copy Markdown

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-32404, which is invalid:

  • expected dependent Jira Issue OCPBUGS-32228 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/lgtm
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
@muraee

muraee commented May 14, 2024

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented May 14, 2024

Copy link
Copy Markdown

@muraee: This pull request references Jira Issue OCPBUGS-32404, which is invalid:

  • expected dependent Jira Issue OCPBUGS-32228 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@muraee muraee changed the title OCPBUGS-32404: Fix failure to create a second hostedcluster in the same namespace [release-4.15] OCPBUGS-32404: Fix failure to create a second hostedcluster in the same namespace May 14, 2024
@muraee

muraee commented Jun 19, 2024

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 19, 2024
@openshift-ci-robot

openshift-ci-robot commented Jun 19, 2024

Copy link
Copy Markdown

@muraee: This pull request references Jira Issue OCPBUGS-32404, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-32228 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-32228 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (heli@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 19, 2024
@openshift-ci-robot

openshift-ci-robot commented Jun 19, 2024

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 2bc16c5 and 2 for PR HEAD 37ab8e5 in total

@openshift-ci

openshift-ci Bot commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

@muraee: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 9c62624 into openshift:release-4.15 Jun 19, 2024
@openshift-ci-robot

openshift-ci-robot commented Jun 19, 2024

Copy link
Copy Markdown

@muraee: Jira Issue OCPBUGS-32404: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32404 has been moved to the MODIFIED state.

Details

In response to this:

manual cherry-pick of #3900

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot

openshift-merge-robot commented Jun 20, 2024

Copy link
Copy Markdown
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-06-20-070602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hasueki hasueki Awaiting requested review from hasueki
@sjenning sjenning Awaiting requested review from sjenning

Assignees

@stevekuznetsov stevekuznetsov

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@muraee @openshift-ci-robot @stevekuznetsov @openshift-merge-robot