HOSTEDCP-1285: Kas port svc cleanup

[enxebre]

What this PR does / why we need it:
The kas SVC port is an impl detail. Before this change their value was wrongly conflated with the spec.metworking.apiServer.port input.
If we ever require the dedicated KAS LB port to be a choice, that would be input in the LB publishing strategy.

Goes after #3185

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[enxebre]

/hold
Goes after #3185

[openshift-ci-robot]

@enxebre: This pull request references HOSTEDCP-1285 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@enxebre: This pull request references HOSTEDCP-1285 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:
The kas SVC port is an impl detail. Before this change their value was wrongly conflated with the spec.metworking.apiServer.port input.
If we ever require the dedicated KAS LB port to be a choice, that would be input in the LB publishing strategy.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@enxebre: This pull request references HOSTEDCP-1285 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:
The kas SVC port is an impl detail. Before this change their value was wrongly conflated with the spec.metworking.apiServer.port input.
If we ever require the dedicated KAS LB port to be a choice, that would be input in the LB publishing strategy.

Goes after #3185

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[netlify]

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	dbbb951
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/6557148a524029000878fbe0
😎 Deploy Preview	https://deploy-preview-3186--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[enxebre]

/hold cancel

[csrwng]

My only comment is that it would be good to have a constant for the Azure port even if it's a hack. It should make it easier to find all references when we do want to remove the hack.

Other than that, lgtm

[csrwng]

/lgtm

[enxebre]

/test e2e-kubevirt-aws-ovn

[openshift-ci]

@enxebre: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[csrwng]

/lgtm

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.15.0-202311171651.p0.g3f4fce6.assembly.stream for distgit hypershift.
All builds following this will include this PR.