Repository navigation
Add enhancement proposal for SDN live migration - #1064
Merged
Merged
Conversation
Author
|
/cc @trozet @cgwalters @squeed PTAL. |
jewzaam
reviewed
Mar 18, 2022
danwinship
reviewed
Mar 21, 2022
cgwalters
reviewed
Mar 21, 2022
Author
|
/cc @russellb |
russellb
reviewed
Apr 4, 2022
pliurh
force-pushed
the
live-migration
branch
3 times, most recently
from
April 21, 2022 11:19
223d158 to
fadbcfe
Compare
dcbw
reviewed
May 24, 2022
dcbw
reviewed
May 24, 2022
dcbw
reviewed
Jun 14, 2022
dcbw
reviewed
Jun 14, 2022
pliurh
force-pushed
the
live-migration
branch
3 times, most recently
from
June 28, 2022 07:40
fb265d5 to
650b339
Compare
|
Inactive enhancement proposals go stale after 28d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
openshift-ci
Bot
added
the
lifecycle/stale
Author
|
/remove-lifecycle stale |
openshift-ci
Bot
removed
the
lifecycle/stale
|
Inactive enhancement proposals go stale after 28d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
openshift-ci
Bot
added
the
lifecycle/stale
Author
|
/remove-lifecycle stale |
openshift-ci
Bot
removed
the
lifecycle/stale
jcaamano
reviewed
Oct 18, 2023
pliurh
force-pushed
the
live-migration
branch
2 times, most recently
from
October 23, 2023 07:03
5ccc533 to
6627327
Compare
jcaamano
reviewed
Oct 23, 2023
pliurh
force-pushed
the
live-migration
branch
from
October 23, 2023 14:20
6627327 to
318dfb5
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
Contributor
|
/hold @pliurh in case you need more feedback. Feel free to unhold |
openshift-ci
Bot
added
the
do-not-merge/hold
kyrtapz
reviewed
Oct 25, 2023
| 1400 for OVN Kubernetes and 1450 for OpenShift SDN. During the migration, this | ||
| MTU mismatch would break some cross-CNI traffic. | ||
|
|
||
| To avoid this issue, before starting the migration, users need to decrease the |
Contributor
There was a problem hiding this comment.
Is MTU migration automated or not?
This sentence suggests that it is not but there is also this one:
CNO will check the current hardware MTU and the cluster MTU to see if there is enough free space for OVN-K overlay overhead
Author
There was a problem hiding this comment.
MTU migration will be part of the live migration, so it will be automated. Let me make the sentences more clear.
Contributor
There was a problem hiding this comment.
Just a clarification: it is only automated in the scope of this procedure because it doesn't contemplate the need to update the physical network MTU. This probably worth adding as well.
Signed-off-by: Peng Liu <pliu@redhat.com>
pliurh
force-pushed
the
live-migration
branch
from
October 25, 2023 14:22
318dfb5 to
7c8bfe3
Compare
Contributor
|
/lgtm |
Author
|
/unhold |
openshift-ci
Bot
removed
the
do-not-merge/hold
Contributor
|
@pliurh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
martinkennelly
added a commit
to martinkennelly/release
that referenced
this pull request
Jan 19, 2024
For details of the CNI migration feature see the feature enhancement PR [1]. Within o/origin, there is a suite for live migration. The suite accepts one environment variable. The value of this environment variable controls which CNI we are migrating to and optionally, if we want to trigger rollback. Rollback will only start once live migration to the target CNI is complete. If the environemnt variables value is blank, live migration test will be skipped. For more info, see the o/origin live migration PR [2]. Note: enabling of eip feature tests depends on fixing a bug [3]. A bug to track this enabling has also been created [4]. [1] openshift/enhancements#1064 [2] openshift/origin#28462 [3] https://issues.redhat.com/browse/OCPBUGS-26196 [4] https://issues.redhat.com/browse/NP-884 Signed-off-by: Martin Kennelly <mkennell@redhat.com>
openshift-merge-bot Bot
pushed a commit
to openshift/release
that referenced
this pull request
Jan 23, 2024
For details of the CNI migration feature see the feature enhancement PR [1]. Within o/origin, there is a suite for live migration. The suite accepts one environment variable. The value of this environment variable controls which CNI we are migrating to and optionally, if we want to trigger rollback. Rollback will only start once live migration to the target CNI is complete. If the environemnt variables value is blank, live migration test will be skipped. For more info, see the o/origin live migration PR [2]. Note: enabling of eip feature tests depends on fixing a bug [3]. A bug to track this enabling has also been created [4]. [1] openshift/enhancements#1064 [2] openshift/origin#28462 [3] https://issues.redhat.com/browse/OCPBUGS-26196 [4] https://issues.redhat.com/browse/NP-884 Signed-off-by: Martin Kennelly <mkennell@redhat.com>
skordas
pushed a commit
to skordas/release
that referenced
this pull request
Jan 23, 2024
For details of the CNI migration feature see the feature enhancement PR [1]. Within o/origin, there is a suite for live migration. The suite accepts one environment variable. The value of this environment variable controls which CNI we are migrating to and optionally, if we want to trigger rollback. Rollback will only start once live migration to the target CNI is complete. If the environemnt variables value is blank, live migration test will be skipped. For more info, see the o/origin live migration PR [2]. Note: enabling of eip feature tests depends on fixing a bug [3]. A bug to track this enabling has also been created [4]. [1] openshift/enhancements#1064 [2] openshift/origin#28462 [3] https://issues.redhat.com/browse/OCPBUGS-26196 [4] https://issues.redhat.com/browse/NP-884 Signed-off-by: Martin Kennelly <mkennell@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peng Liu pliu@redhat.com