Bug 1960559: drop APIExtensions v1beta1 by vrutkovs · Pull Request #566 · openshift/cluster-version-operator

vrutkovs · 2021-05-14T08:39:14Z

All manifests have moved to v1.

This also bumps openshift/api (and updates k8s deps to 0.21.1 to be uniform) so that all apiextensions/v1beta1 would no longer be used.

openshift-ci · 2021-05-14T08:39:22Z

@vrutkovs: This pull request references Bugzilla bug 1960559, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianlinliu

Details

In response to this:

Bug 1960559: drop APIExtensions v1beta1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs · 2021-05-14T08:40:09Z

/hold

I'd prefer RBACv1beta1 PR to land first

vrutkovs · 2021-05-17T08:02:01Z

/hold cancel

vrutkovs · 2021-05-18T07:29:06Z

/retest

openshift-ci · 2021-05-18T09:22:09Z

@vrutkovs: This pull request references Bugzilla bug 1960559, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianlinliu

Details

In response to this:

Bug 1960559: drop APIExtensions v1beta1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs · 2021-05-18T09:50:59Z

/test unit

Flake

vrutkovs · 2021-05-18T11:18:22Z

/retest

Failed to setup initial cluster in upgrade test

LalatenduMohanty · 2021-05-18T19:24:36Z

/test e2e-agnostic-upgrade

vrutkovs · 2021-05-19T13:38:30Z

/retest

vrutkovs · 2021-05-21T08:21:23Z

/retest

sttts · 2021-05-25T07:47:14Z

 			}
-			var crd v1beta1.CustomResourceDefinition
+			var crd v1.CustomResourceDefinition
 			if err := yaml.Unmarshal(data, &crd); err != nil {


You don't check that the API version matches? That's not going to make you happy when it doesn't.

ok, test only.

I don't think we do that in tests. In actual flow non-v1 CRDs would be treated as "unstructered".

@wking @LalatenduMohanty any advice here? I suppose we should be tracking how many manifests are being applied by unstructured handler and attempt to minimize that number. Probably we should be exporting a new metric?

My long-term goal is to completely drop the unstructured handler, and fail folks in CI if they add a new manifest type that we don't support. Logging in the unstructured handler that we can look for in gathered CI assets would help get us there.

if they add a new manifest type that we don't support. Logging in the unstructured handler that we can look for in gathered CI assets would help get us there.

+1

vrutkovs · 2021-05-26T08:19:24Z

/test e2e-agnostic-upgrade

LalatenduMohanty · 2021-05-26T21:12:17Z

/test e2e-agnostic-upgrade

vrutkovs · 2021-06-03T09:15:58Z

/test unit

LalatenduMohanty · 2021-06-07T15:44:01Z

/test e2e-agnostic-upgrade

No manifests in 4.8 payload are using it

All manifests have moved to v1

vrutkovs · 2021-06-14T14:43:26Z

/bugzilla refresh
/retest

openshift-ci · 2021-06-14T14:43:29Z

@vrutkovs: This pull request references Bugzilla bug 1960559, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs · 2021-06-14T14:44:09Z

/bugzilla refresh

openshift-ci · 2021-06-14T14:44:13Z

@vrutkovs: This pull request references Bugzilla bug 1960559, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianlinliu

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs · 2021-06-15T07:22:07Z

/retest

wking

/lgtm

pods should successfully create sandboxes by other and etcdHighNumberOfLeaderChanges are unrelated.

/override ci/prow/e2e-agnostic-upgrade

openshift-ci · 2021-06-15T13:34:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [vrutkovs,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-06-15T13:34:38Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

/lgtm

pods should successfully create sandboxes by other and etcdHighNumberOfLeaderChanges are unrelated.

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2021-06-15T17:28:52Z

The HAProxy router should set Forwarded headers appropriately is unrelated.

/override ci/prow/e2e-agnostic

openshift-ci · 2021-06-15T17:29:04Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic

Details

In response to this:

The HAProxy router should set Forwarded headers appropriately is unrelated.

/override ci/prow/e2e-agnostic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2021-06-15T17:29:56Z

This PR is unrelated to the other recent changes, so save some time and money with a manual merge to cut off the retesting.

openshift-ci · 2021-06-15T17:30:06Z

@vrutkovs: All pull requests linked via external trackers have merged:

openshift/cluster-version-operator#566

Bugzilla bug 1960559 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1960559: drop APIExtensions v1beta1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-06-15T20:57:45Z

@vrutkovs: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-agnostic-upgrade	`8f5294d`	link	`/test e2e-agnostic-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The original APIService reconciliation landed in 662e182 (handle APIService, Service objects, 2018-09-27, openshift#26). We definitely reconcile a bunch of Service manifests (e.g. for serving operator metrics, including the CVO's own Service), but it's not clear what the use case was for APIService. DeleteAPIServicev1 landed in 0afb8a8 (Add a manifest annotation to be used for object deletion, 2020-08-17, openshift#438), but was never consumed. We dropped APIService reconciliation support in 5681a70 (Drop APIService support, 2021-06-10, openshift#566). This commit drops the unused DeleteAPIServicev1. Auditing z-stream tips from 4.3 through 4.11: $ oc adm release extract --to 4.11 quay.io/openshift-release-dev/ocp-release-nightly@sha256:080e5cf5e3e043ac0877b8f545ba2b596016f3fd76f3f457d15060603b3615e1 $ oc adm release extract --to 4.10 quay.io/openshift-release-dev/ocp-release:4.10.13-x86_64 $ oc adm release extract --to 4.9 quay.io/openshift-release-dev/ocp-release:4.9.32-x86_64 $ oc adm release extract --to 4.8 quay.io/openshift-release-dev/ocp-release:4.8.39-x86_64 $ oc adm release extract --to 4.7 quay.io/openshift-release-dev/ocp-release:4.7.50-x86_64 $ oc adm release extract --to 4.6 quay.io/openshift-release-dev/ocp-release:4.6.57-x86_64 $ oc adm release extract --to 4.5 quay.io/openshift-release-dev/ocp-release:4.5.41-x86_64 $ oc adm release extract --to 4.4 quay.io/openshift-release-dev/ocp-release:4.4.33-x86_64 $ oc adm release extract --to 4.3 quay.io/openshift-release-dev/ocp-release:4.3.40-x86_64 $ grep -r 'kind: APIService' 4.* ...no hits...

openshift-ci Bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label May 14, 2021

openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 14, 2021

openshift-ci Bot requested review from LalatenduMohanty, jianlinliu and wking May 14, 2021 08:39

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2021

openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 14, 2021

vrutkovs force-pushed the drop-v1beta1 branch from 7abb6a0 to f6cfda4 Compare May 17, 2021 08:01

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2021

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2021

vrutkovs force-pushed the drop-v1beta1 branch from f6cfda4 to 2d11ea4 Compare May 18, 2021 09:21

vrutkovs mentioned this pull request May 18, 2021

Bug 1947797: Bumping openshift/api to vendor apiextensions.k8s.io/v1 #567

Merged

vrutkovs force-pushed the drop-v1beta1 branch from 2d11ea4 to 3a11b60 Compare May 25, 2021 07:43

sttts reviewed May 25, 2021

View reviewed changes

vrutkovs force-pushed the drop-v1beta1 branch from 3a11b60 to a82cc0d Compare May 25, 2021 08:57

openshift-ci Bot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 27, 2021

vrutkovs force-pushed the drop-v1beta1 branch from a82cc0d to 39963b9 Compare May 31, 2021 07:33

openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 31, 2021

vrutkovs force-pushed the drop-v1beta1 branch from 39963b9 to a3057c9 Compare June 3, 2021 08:17

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2021

Vadim Rutkovsky added 2 commits June 10, 2021 10:07

Drop APIService support

5681a70

No manifests in 4.8 payload are using it

Drop APIExtensions v1beta1

8f5294d

All manifests have moved to v1

vrutkovs force-pushed the drop-v1beta1 branch from a3057c9 to 8f5294d Compare June 10, 2021 08:08

openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 14, 2021

openshift-ci Bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 14, 2021

wking approved these changes Jun 15, 2021

View reviewed changes

openshift-ci Bot assigned wking Jun 15, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021

wking merged commit 2fbdb38 into openshift:master Jun 15, 2021

wking mentioned this pull request May 9, 2022

Bug 2081895: lib/resourcebuilder/apiext: Restore check for Established=True CRDs #771

Merged

Uh oh!

Conversation

vrutkovs commented May 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented May 14, 2021

Uh oh!

vrutkovs commented May 14, 2021

Uh oh!

vrutkovs commented May 17, 2021

Uh oh!

vrutkovs commented May 18, 2021

Uh oh!

openshift-ci Bot commented May 18, 2021

Uh oh!

vrutkovs commented May 18, 2021

Uh oh!

vrutkovs commented May 18, 2021

Uh oh!

LalatenduMohanty commented May 18, 2021

Uh oh!

vrutkovs commented May 19, 2021

Uh oh!

vrutkovs commented May 21, 2021

Uh oh!

sttts May 25, 2021

Choose a reason for hiding this comment

Uh oh!

sttts May 25, 2021

Choose a reason for hiding this comment

Uh oh!

vrutkovs May 25, 2021

Choose a reason for hiding this comment

Uh oh!

wking May 25, 2021

Choose a reason for hiding this comment

Uh oh!

LalatenduMohanty May 25, 2021

Choose a reason for hiding this comment

Uh oh!

vrutkovs commented May 26, 2021

Uh oh!

LalatenduMohanty commented May 26, 2021

Uh oh!

vrutkovs commented Jun 3, 2021

Uh oh!

LalatenduMohanty commented Jun 7, 2021

Uh oh!

vrutkovs commented Jun 14, 2021

Uh oh!

openshift-ci Bot commented Jun 14, 2021

Uh oh!

vrutkovs commented Jun 14, 2021

Uh oh!

openshift-ci Bot commented Jun 14, 2021

Uh oh!

vrutkovs commented Jun 15, 2021

Uh oh!

wking left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jun 15, 2021

Uh oh!

openshift-ci Bot commented Jun 15, 2021

Uh oh!

wking commented Jun 15, 2021

Uh oh!

openshift-ci Bot commented Jun 15, 2021

Uh oh!

wking commented Jun 15, 2021

Uh oh!

openshift-ci Bot commented Jun 15, 2021

Uh oh!

openshift-ci Bot commented Jun 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

vrutkovs commented May 14, 2021 •

edited

Loading