Skip to content

*: fix a few issues - #3

Merged
crawford merged 2 commits into
openshift:masterfrom
crawford:fixes
Aug 2, 2018
Merged

*: fix a few issues#3
crawford merged 2 commits into
openshift:masterfrom
crawford:fixes

Conversation

@crawford

@crawford crawford commented Aug 2, 2018

Copy link
Copy Markdown
Contributor

No description provided.

It's possible that two instances of the CVO could run in a single pod.
The UUID will protect against this case.
The previous implementation didn't account for the opening and closing
quotes that surround a string.

This also updates the default upstream Cincinnati URL to include the
graph API endpoint.
@crawford
crawford requested a review from abhinavdahiya August 2, 2018 02:55
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 2, 2018
@crawford
crawford merged commit b2915c1 into openshift:master Aug 2, 2018
@crawford
crawford deleted the fixes branch August 2, 2018 18:26
openshift-merge-bot Bot pushed a commit that referenced this pull request Jun 26, 2026
install: Update skill name and terminology in lightspeed prompts
jhadvig added a commit to jhadvig/cluster-version-operator that referenced this pull request Jul 21, 2026
- Skip manifest cleanup if disableConsolePlugin fails, to avoid
  removing backing resources while the plugin is still registered
  in the console config (wking review openshift#1)
- Wait for at least one available replica before enabling the plugin
  in the console config, so the console doesn't try to load a plugin
  whose backing pod isn't ready yet (wking review openshift#2)
- consolePluginEnsured remains a TP-acceptable volatile cache; active
  reconciliation of owned resources is deferred to pre-GA (wking openshift#3)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants