OCPBUGS-113532: ovn-kubernetes: Move MNP from ConfigMap to CLI flags by raphaelvrosa · Pull Request #3136 · openshift/cluster-network-operator

raphaelvrosa · 2026-08-24T14:12:54Z

MultiNetworkPolicy is not enforced on UDN secondary interfaces in OCP 5.0 because ovnkube-control-plane pods do not restart when the ConfigMap is updated with enable-multi-networkpolicy=true.

Root cause: PR #2944 moved MNP enablement to ConfigMap, but:

The ConfigMap hash only includes 008-script-lib.yaml, not 004-config.yaml
ovnkube-control-plane has no hash annotation to trigger restarts

Solution: Follow the same pattern as commit f4734c5 (OCPBUGS-78731): move MNP back to CLI flags where pod restart happens automatically on spec changes.

This creates consistency with multicast (also a CLI flag) and avoids the ConfigMap hash timing issues that caused the original NVIDIA-554 fix to be reverted.

How to verify:

Deploy cluster with UseMultiNetworkPolicy=false
- Verify ovnkube-control-plane pods lack --enable-multi-networkpolicy flag
Set UseMultiNetworkPolicy=true via network.operator/cluster
- Verify ovnkube-control-plane pods restart with --enable-multi-networkpolicy
Test MNP enforcement on UDN Layer2/Layer3 networks
Verify DPU-host mode still works correctly
CI lanes: e2e-aws-ovn, e2e-gcp-ovn, e2e-metal-ipi-ovn-dualstack

Tested:

MNP works on UDN Layer2 and Layer3 networks
Pods restart when UseMultiNetworkPolicy changes
DPU-host mode still works correctly
Other ConfigMap features (egress-ip, etc.) unaffected

Jira: OCPBUGS-88063

docs: Clarify CLI flags are for control-plane pod restarts

Update ovn_node_mode.md to specify that CLI flags are used for features requiring ovnkube-control-plane pod restarts, not just any pod restarts. This clarifies that ovnkube-node pods already restart when the ConfigMap changes, so CLI flags are only needed for control-plane-specific features.

Addresses review feedback from danwinship.

(cherry picked from commit 17f08a7)

MultiNetworkPolicy is not enforced on UDN secondary interfaces in OCP 5.0 because ovnkube-control-plane pods do not restart when the ConfigMap is updated with enable-multi-networkpolicy=true. Root cause: PR openshift#2944 moved MNP enablement to ConfigMap, but: 1. The ConfigMap hash only includes 008-script-lib.yaml, not 004-config.yaml 2. ovnkube-control-plane has no hash annotation to trigger restarts Solution: Follow the same pattern as commit f4734c5 (OCPBUGS-78731): move MNP back to CLI flags where pod restart happens automatically on spec changes. This creates consistency with multicast (also a CLI flag) and avoids the ConfigMap hash timing issues that caused the original NVIDIA-554 fix to be reverted. How to verify: 1. Deploy cluster with UseMultiNetworkPolicy=false - Verify ovnkube-control-plane pods lack --enable-multi-networkpolicy flag 2. Set UseMultiNetworkPolicy=true via network.operator/cluster - Verify ovnkube-control-plane pods restart with --enable-multi-networkpolicy 3. Test MNP enforcement on UDN Layer2/Layer3 networks 4. Verify DPU-host mode still works correctly 5. CI lanes: e2e-aws-ovn, e2e-gcp-ovn, e2e-metal-ipi-ovn-dualstack Tested: - MNP works on UDN Layer2 and Layer3 networks - Pods restart when UseMultiNetworkPolicy changes - DPU-host mode still works correctly - Other ConfigMap features (egress-ip, etc.) unaffected Jira: OCPBUGS-88063 docs: Clarify CLI flags are for control-plane pod restarts Update ovn_node_mode.md to specify that CLI flags are used for features requiring ovnkube-control-plane pod restarts, not just any pod restarts. This clarifies that ovnkube-node pods already restart when the ConfigMap changes, so CLI flags are only needed for control-plane-specific features. Addresses review feedback from danwinship. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> (cherry picked from commit 17f08a7)

openshift-merge-bot · 2026-08-24T14:12:57Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

coderabbitai · 2026-08-24T14:13:03Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4f5dbef9-7941-4782-8a75-862e049d5fed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-08-24T14:13:19Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raphaelvrosa
Once this PR has been reviewed and has the lgtm label, please assign tssurya for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-08-24T14:16:08Z

@raphaelvrosa: This pull request references Jira Issue OCPBUGS-113532, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-88063 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-88063 targets the "5.0" version, which is one of the valid target versions: 5.0.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (core-networking-bot@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

MultiNetworkPolicy is not enforced on UDN secondary interfaces in OCP 5.0 because ovnkube-control-plane pods do not restart when the ConfigMap is updated with enable-multi-networkpolicy=true.

Root cause: PR #2944 moved MNP enablement to ConfigMap, but:

The ConfigMap hash only includes 008-script-lib.yaml, not 004-config.yaml

ovnkube-control-plane has no hash annotation to trigger restarts

Solution: Follow the same pattern as commit f4734c5 (OCPBUGS-78731): move MNP back to CLI flags where pod restart happens automatically on spec changes.

This creates consistency with multicast (also a CLI flag) and avoids the ConfigMap hash timing issues that caused the original NVIDIA-554 fix to be reverted.

How to verify:

Deploy cluster with UseMultiNetworkPolicy=false

Verify ovnkube-control-plane pods lack --enable-multi-networkpolicy flag

Set UseMultiNetworkPolicy=true via network.operator/cluster

Verify ovnkube-control-plane pods restart with --enable-multi-networkpolicy

Test MNP enforcement on UDN Layer2/Layer3 networks

Verify DPU-host mode still works correctly

CI lanes: e2e-aws-ovn, e2e-gcp-ovn, e2e-metal-ipi-ovn-dualstack

Tested:

MNP works on UDN Layer2 and Layer3 networks

Pods restart when UseMultiNetworkPolicy changes

DPU-host mode still works correctly

Other ConfigMap features (egress-ip, etc.) unaffected

Jira: OCPBUGS-88063

docs: Clarify CLI flags are for control-plane pod restarts

Update ovn_node_mode.md to specify that CLI flags are used for features requiring ovnkube-control-plane pod restarts, not just any pod restarts. This clarifies that ovnkube-node pods already restart when the ConfigMap changes, so CLI flags are only needed for control-plane-specific features.

Addresses review feedback from danwinship.

(cherry picked from commit 17f08a7)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

raphaelvrosa · 2026-08-24T16:38:24Z

/pipeline required

openshift-merge-bot · 2026-08-24T16:38:27Z

Scheduling required tests:
/test e2e-aws-ovn-upgrade-ipsec

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test 4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade
/test 4.22-upgrade-from-stable-4.21-e2e-azure-ovn-upgrade
/test 4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade
/test e2e-aws-ovn-fdp-qe
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-windows
/test e2e-azure-ovn-upgrade
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-dualstack-bgp
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-ovn-ipv6-ipsec
/test e2e-ovn-ipsec-step-registry
/test hypershift-e2e-aks

openshift-ci · 2026-08-24T22:29:51Z

@raphaelvrosa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade	`4c976c2`	link	false	`/test 4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade`
ci/prow/e2e-aws-ovn-upgrade	`4c976c2`	link	true	`/test e2e-aws-ovn-upgrade`
ci/prow/4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade	`4c976c2`	link	false	`/test 4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade`
ci/prow/security	`4c976c2`	link	false	`/test security`
ci/prow/e2e-ovn-ipsec-step-registry	`4c976c2`	link	true	`/test e2e-ovn-ipsec-step-registry`
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw	`4c976c2`	link	true	`/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw`
ci/prow/e2e-aws-ovn-hypershift-conformance	`4c976c2`	link	true	`/test e2e-aws-ovn-hypershift-conformance`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci Bot requested review from bpickard22 and miheer August 24, 2026 14:13

raphaelvrosa changed the title ~~ovn-kubernetes: Move MNP from ConfigMap to CLI flags~~ OCPBUGS-113532: ovn-kubernetes: Move MNP from ConfigMap to CLI flags Aug 24, 2026

Navigation Menu

Uh oh!

OCPBUGS-113532: ovn-kubernetes: Move MNP from ConfigMap to CLI flags - #3136

OCPBUGS-113532: ovn-kubernetes: Move MNP from ConfigMap to CLI flags#3136
raphaelvrosa wants to merge 1 commit into
openshift:release-4.22from
raphaelvrosa:88063-release-4.22

raphaelvrosa commented Aug 24, 2026 •

edited by openshift-ci Bot

Loading

Uh oh!

openshift-merge-bot Bot commented Aug 24, 2026

Uh oh!

coderabbitai Bot commented Aug 24, 2026

Review skipped

Uh oh!

openshift-ci Bot commented Aug 24, 2026

Uh oh!

openshift-ci-robot commented Aug 24, 2026

Uh oh!

raphaelvrosa commented Aug 24, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 24, 2026

Uh oh!

openshift-ci Bot commented Aug 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

raphaelvrosa commented Aug 24, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-merge-bot Bot commented Aug 24, 2026

Uh oh!

coderabbitai Bot commented Aug 24, 2026

Review skipped

Uh oh!

openshift-ci Bot commented Aug 24, 2026

Uh oh!

openshift-ci-robot commented Aug 24, 2026

Uh oh!

raphaelvrosa commented Aug 24, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 24, 2026

Uh oh!

openshift-ci Bot commented Aug 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

raphaelvrosa commented Aug 24, 2026 •

edited by openshift-ci Bot

Loading