Skip to content

Bug 1939855: controllers/updateservice_controller.go: handle init container changes - #150

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
jottofar:bug-1939855
Nov 7, 2022
Merged

Bug 1939855: controllers/updateservice_controller.go: handle init container changes#150
openshift-merge-robot merged 1 commit into
openshift:masterfrom
jottofar:bug-1939855

Conversation

@jottofar

Copy link
Copy Markdown
Contributor

such as graphDataImage updates.

@openshift-ci openshift-ci Bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 13, 2022
@openshift-ci

openshift-ci Bot commented Oct 13, 2022

Copy link
Copy Markdown
Contributor

@jottofar: This pull request references Bugzilla bug 1939855, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jiajliu

Details

In response to this:

Bug 1939855: controllers/updateservice_controller.go: handle init container changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
@jottofar

Copy link
Copy Markdown
Contributor Author

/test operator-e2e

Comment thread controllers/updateservice_controller.go Outdated
Comment thread controllers/updateservice_controller.go Outdated

@PratikMahajan PratikMahajan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@PratikMahajan

Copy link
Copy Markdown
Contributor

/override ci/prow/operator-e2e

operator-e2e is pinned to a specific commit which does not contain the fix for sha-sum mismatch.
ci/prow/operator-e2e-latest-osus uses the latest commit from cincinnati and has passed the tests.

@openshift-ci

openshift-ci Bot commented Nov 1, 2022

Copy link
Copy Markdown
Contributor

@PratikMahajan: PratikMahajan unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight.

Details

In response to this:

/override ci/prow/operator-e2e

operator-e2e is pinned to a specific commit which does not contain the fix for sha-sum mismatch.
ci/prow/operator-e2e-latest-osus uses the latest commit from cincinnati and has passed the tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jottofar

jottofar commented Nov 1, 2022

Copy link
Copy Markdown
Contributor Author

/override ci/prow/operator-e2e

operator-e2e is pinned to a specific commit which does not contain the fix for sha-sum mismatch.
ci/prow/operator-e2e-latest-osus uses the latest commit from cincinnati and has passed the tests.

@openshift-ci

openshift-ci Bot commented Nov 1, 2022

Copy link
Copy Markdown
Contributor

@jottofar: Overrode contexts on behalf of jottofar: ci/prow/operator-e2e

Details

In response to this:

/override ci/prow/operator-e2e

operator-e2e is pinned to a specific commit which does not contain the fix for sha-sum mismatch.
ci/prow/operator-e2e-latest-osus uses the latest commit from cincinnati and has passed the tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@openshift-ci

openshift-ci Bot commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jottofar

jottofar commented Nov 7, 2022

Copy link
Copy Markdown
Contributor Author

/override ci/prow/operator-e2e

operator-e2e is pinned to a specific commit which does not contain the fix for sha-sum mismatch.
ci/prow/operator-e2e-latest-osus uses the latest commit from cincinnati and has passed the tests.

@openshift-ci

openshift-ci Bot commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

@jottofar: Overrode contexts on behalf of jottofar: ci/prow/operator-e2e

Details

In response to this:

/override ci/prow/operator-e2e

operator-e2e is pinned to a specific commit which does not contain the fix for sha-sum mismatch.
ci/prow/operator-e2e-latest-osus uses the latest commit from cincinnati and has passed the tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci

openshift-ci Bot commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

@jottofar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
openshift-merge-robot merged commit 6babbc3 into openshift:master Nov 7, 2022
@openshift-ci

openshift-ci Bot commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

@jottofar: All pull requests linked via external trackers have merged:

Bugzilla bug 1939855 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1939855: controllers/updateservice_controller.go: handle init container changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants