This repository was archived by the owner on Jun 14, 2019. It is now read-only.
Change the configuration file format to YAML - #121
Merged
openshift-merge-robot merged 1 commit intoAug 31, 2018
Merged
Conversation
openshift-ci-robot
added
the
size/L
Member
Author
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
This was referenced Aug 31, 2018
Member
Author
|
/cc @stevekuznetsov |
stevekuznetsov
left a comment
stevekuznetsov
left a comment
Contributor
There was a problem hiding this comment.
That's nice and clean :)
/lgtm
openshift-ci-robot
added
lgtm
Contributor
|
/approve |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSIA
JSON is a subset of YAML, so
ci-operatorwill be able to read also old JSON configs. Using https://github.com/ghodss/yaml means the necessary code changes are minimal because it reuses thejsonstruct member annotations plus it's already vendored (it's used for similar purposes at least by k8s.io/test-infra).Resolves: #46