Update APIServer to make room for audit profile - #681
Conversation
|
work in progress /hold |
openshift-ci-robot
added
do-not-merge/hold
tkashem
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
tkashem
changed the title
|
ready for review /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
| TLSSecurityProfile *TLSSecurityProfile `json:"tlsSecurityProfile,omitempty"` | ||
| // audit specifies the settings for audit configuration to be applied to all OpenShift-provided | ||
| // API servers in the cluster. | ||
| Audit Audit `json:"audit,omitempty"` |
There was a problem hiding this comment.
remove omitempty. This has no effect.
There was a problem hiding this comment.
We also need a default marker here afaik, with {"profile":"Default"}
| // - WriteRequestBodies | ||
| // - AllRequestBodies | ||
| // If unset, the 'Default' profile is used as the default. | ||
| Profile AuditProfileType `json:"profile,omitempty"` |
There was a problem hiding this comment.
add kubebuilder marker for a default "Default"
There was a problem hiding this comment.
plus an enum marker for the three values
There was a problem hiding this comment.
There was a problem hiding this comment.
plus an enum marker for the three values
still missing
There was a problem hiding this comment.
@sttts I have put it where the enum is declared - https://github.com/openshift/api/pull/681/files#diff-2a98fd5f6a0f42f75cdc7d0bfbeb4333R62-R63
you want me to move it here?
There was a problem hiding this comment.
Nope. You way is even better 👍
| configuration to be deployed to all OpenShift-provided API servers | ||
| in the cluster \n We provide the following profiles - Default | ||
| - WriteRequestBodies - AllRequestBodies If unset, the 'Default' | ||
| profile is used as the default." |
There was a problem hiding this comment.
how about specifying them a bit more?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
4 participants
No description provided.