Skip to content

config/v1/types_cluster_operator: "the kube ecosystem" -> "the Kubernetes ecosystem" - #500

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
wking:expand-kube-abbreviation
Nov 5, 2019
Merged

config/v1/types_cluster_operator: "the kube ecosystem" -> "the Kubernetes ecosystem"#500
openshift-merge-robot merged 1 commit into
openshift:masterfrom
wking:expand-kube-abbreviation

Conversation

@wking

@wking wking commented Oct 28, 2019

Copy link
Copy Markdown
Member

The abbreviated wording was originally from 898d7e3 (#127). But using the full name in these docs gives readers one less abbreviation to recognize.

…etes ecosystem"

The abbreviated wording was originally from 898d7e3 (api: Move
ClusterVersion/ClusterOperator into config.openshift.io, 2018-11-09, openshift#127).
But using the full name in these docs gives readers one less
abbreviation to recognize.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2019
@wking
wking force-pushed the expand-kube-abbreviation branch from 2ea87bd to 0841387 Compare October 28, 2019 16:36
@damemi

damemi commented Oct 28, 2019

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2019

@soltysh soltysh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment update.
/lgtm
/approve

@openshift-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, soltysh, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2019
@openshift-merge-robot
openshift-merge-robot merged commit 98fa823 into openshift:master Nov 5, 2019
@wking
wking deleted the expand-kube-abbreviation branch November 6, 2019 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants