We're working to move the MCO types from the machine-config-operator repo. Within our types we're using the ignition types https://github.com/openshift/machine-config-operator/blob/master/pkg/apis/machineconfiguration.openshift.io/v1/types.go#L233. We're already doing an hack to provide DeepCopy https://github.com/openshift/machine-config-operator/blob/master/pkg/apis/machineconfiguration.openshift.io/v1/machineconfig.deepcopy.go but we're now stuck because the Ignition types don't have protobuf annotations (nor the generate target writes them ofc). This result in make generate working just fine except for the protobuf case because of Ignition. I can see a $PROTO_OPTIONAL env but it doesn't seem to take effect.
Do we need to have ingnition types also have protobuf annotation? can we port the api w/o protobuf?
We do have a WIP PR here runcom#1 which fails at the bare make target because of protobuf as said.
We're working to move the MCO types from the machine-config-operator repo. Within our types we're using the ignition types https://github.com/openshift/machine-config-operator/blob/master/pkg/apis/machineconfiguration.openshift.io/v1/types.go#L233. We're already doing an hack to provide DeepCopy https://github.com/openshift/machine-config-operator/blob/master/pkg/apis/machineconfiguration.openshift.io/v1/machineconfig.deepcopy.go but we're now stuck because the Ignition types don't have protobuf annotations (nor the
generatetarget writes them ofc). This result inmake generateworking just fine except for the protobuf case because of Ignition. I can see a$PROTO_OPTIONALenv but it doesn't seem to take effect.Do we need to have ingnition types also have protobuf annotation? can we port the api w/o protobuf?
We do have a WIP PR here runcom#1 which fails at the bare
maketarget because of protobuf as said.