Skip to content

Another attempt to update Ansible and metal3-dev-env - #1666

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift-metal3:masterfrom
dtantsur:new-metal3-dev-env
Jun 24, 2024
Merged

Another attempt to update Ansible and metal3-dev-env#1666
openshift-merge-bot[bot] merged 2 commits into
openshift-metal3:masterfrom
dtantsur:new-metal3-dev-env

Conversation

@dtantsur

@dtantsur dtantsur commented Jun 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

The previous one got reverted because it did not account for certain variable changes.

@openshift-ci
openshift-ci Bot requested review from cybertron and elfosardo June 17, 2024 13:49
@elfosardo

elfosardo commented Jun 18, 2024

Copy link
Copy Markdown
Member

do we want to add the migration to ansible 7 here or open a new PR?
Looking at the logs this passed with the offending change, so it looks good

dtantsur added 2 commits June 18, 2024 13:37
@dtantsur
Reapply "Upgrade to Ansible 7 (openshift-metal3#1523)" (openshift-met…
7d12b68 
…al3#1665)

This reverts commit 258ee33.
@dtantsur
Pass the right interface name to metal3-dev-env firewall config
bf484d2 
The variable got changed upstream but we're still passing the old one.

Remove no longer valid firewalld commands using even older interface
names.
@dtantsur
dtantsur force-pushed the new-metal3-dev-env branch from e9dd072 to bf484d2 Compare June 18, 2024 11:38
@dtantsur dtantsur changed the title Pass the right interface name to metal3-dev-env firewall config Another attempt to update Ansible and metal3-dev-env Jun 18, 2024
@derekhiggins

derekhiggins commented Jun 18, 2024

Copy link
Copy Markdown
Collaborator

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024
@honza

honza commented Jun 18, 2024

Copy link
Copy Markdown
Member

Do we want a newer version of metal3-dev-env? It currently points to a version from April 2023.

@dtantsur

dtantsur commented Jun 18, 2024

Copy link
Copy Markdown
Member Author

Do we want a newer version of metal3-dev-env? It currently points to a version from April 2023.

One step at a time, okay? :) We already have an idea what breaks with this version, the next one will probably need more investigation.

@derekhiggins

derekhiggins commented Jun 19, 2024

Copy link
Copy Markdown
Collaborator

/test e2e-metal-ipi-serial-ipv4

@elfosardo

elfosardo commented Jun 19, 2024

Copy link
Copy Markdown
Member

/retest
failure does not look related

@elfosardo

elfosardo commented Jun 20, 2024

Copy link
Copy Markdown
Member

/retest
timeout in ipv4

@derekhiggins

derekhiggins commented Jun 20, 2024

Copy link
Copy Markdown
Collaborator

/approve

@openshift-ci

openshift-ci Bot commented Jun 20, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2024
@elfosardo

elfosardo commented Jun 21, 2024

Copy link
Copy Markdown
Member

/hold
let's wait for the weekend :)

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2024
@elfosardo

elfosardo commented Jun 21, 2024

Copy link
Copy Markdown
Member

/retest

@elfosardo

elfosardo commented Jun 24, 2024

Copy link
Copy Markdown
Member

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2024
@openshift-merge-bot
openshift-merge-bot Bot merged commit 94fc4df into openshift-metal3:master Jun 24, 2024
@dtantsur
dtantsur deleted the new-metal3-dev-env branch June 24, 2024 10:40
@andreaskaris andreaskaris mentioned this pull request Jul 28, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cybertron cybertron Awaiting requested review from cybertron
@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees

@derekhiggins derekhiggins

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dtantsur @elfosardo @derekhiggins @honza