Skip to content

AGENT-736: Dev-script support for generic external platform - #1611

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-metal3:masterfrom
pawanpinjarkar:agent-external
Dec 7, 2023
Merged

AGENT-736: Dev-script support for generic external platform#1611
openshift-merge-bot[bot] merged 1 commit into
openshift-metal3:masterfrom
pawanpinjarkar:agent-external

Conversation

@pawanpinjarkar

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
@openshift-ci
openshift-ci Bot requested review from bfournie and celebdor November 29, 2023 16:11
@pawanpinjarkar

Copy link
Copy Markdown
Contributor Author

Can be tested by setting


export IP_STACK="v4"
export AGENT_E2E_TEST_SCENARIO=SNO_IPV4
export KNI_INSTALL_FROM_GIT=true
export INSTALLER_REPO_PR=7585
export AGENT_PLATFORM_TYPE=external
export AGENT_PLATFORM_NAME=oci
export AGENT_INSTALLER_API_SERVER_LOCAL_REPO=/home/pawan/assisted-service
export AGENT_INSTALLER_API_SERVER_DOCKERFILE=Dockerfile.assisted-service.ocp
export OPENSHIFT_RELEASE_IMAGE=registry.ci.openshift.org/ocp/release:4.15.0-0.ci-2023-11-28-141749

@pawanpinjarkar

Copy link
Copy Markdown
Contributor Author

Comment thread config_example.sh
@bfournie

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@bfournie

bfournie commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

Tested using latest installer with merged fix for openshift/installer#7585
See the platform set as below and installation appears to be working.

                "platformType": "External",
                "external": {
                    "platformName": "oci"
                }

@bfournie

bfournie commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Dec 7, 2023

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
@openshift-merge-bot
openshift-merge-bot Bot merged commit 74765b9 into openshift-metal3:master Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants