Skip to content

Agent-613: Support imageDigestSources for oc adm release mirror - #1525

Merged
openshift-merge-robot merged 1 commit into
openshift-metal3:masterfrom
bfournie:image-digest-sources
May 2, 2023
Merged

Agent-613: Support imageDigestSources for oc adm release mirror#1525
openshift-merge-robot merged 1 commit into
openshift-metal3:masterfrom
bfournie:image-digest-sources

Conversation

@bfournie

@bfournie bfournie commented Apr 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

In 4.14 the oc adm release mirror command has been updated to output ImageDigestSources instead of ImageContentSources. Update the agent script to handle both.

See openshift/oc#1341 (comment) for the slightly different output.

Also there is a minor fix for inadvertent hardcoding of working dir.

@openshift-ci
openshift-ci Bot requested review from celebdor and rwsu April 28, 2023 00:14
@bfournie

bfournie commented Apr 28, 2023

Copy link
Copy Markdown
Contributor Author

/cc @andfasano

@openshift-ci
openshift-ci Bot requested a review from andfasano April 28, 2023 01:06
andfasano
andfasano reviewed Apr 28, 2023
View reviewed changes
Comment thread agent/05_agent_configure.sh
@bfournie
bfournie force-pushed the image-digest-sources branch from 7cf2fa8 to e994117 Compare April 28, 2023 13:35
@andfasano

andfasano commented Apr 28, 2023

Copy link
Copy Markdown
Member

/approve

@openshift-ci

openshift-ci Bot commented Apr 28, 2023

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2023
@bfournie
Agent-613: Support imageDigestSources for oc adm release mirror
cc9414d 
In 4.14 the `oc adm release mirror` command has been updated to
output ImageDigestSources instead of ImageContentSources. Update
the agent script to handle both.
@bfournie
bfournie force-pushed the image-digest-sources branch from e994117 to cc9414d Compare May 2, 2023 12:19
@bfournie

bfournie commented May 2, 2023

Copy link
Copy Markdown
Contributor Author

/test e2e-agent-sno-ipv6

1 similar comment
@bfournie

bfournie commented May 2, 2023

Copy link
Copy Markdown
Contributor Author

/test e2e-agent-sno-ipv6

@openshift-ci

openshift-ci Bot commented May 2, 2023

Copy link
Copy Markdown

@bfournie: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-sno-ipv6 cc9414d link false /test e2e-agent-sno-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rwsu

rwsu commented May 2, 2023

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2023
@openshift-merge-robot
openshift-merge-robot merged commit e3ad546 into openshift-metal3:master May 2, 2023
@bfournie
bfournie deleted the image-digest-sources branch May 3, 2023 00:56
@andreaskaris andreaskaris mentioned this pull request Jul 28, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@celebdor celebdor Awaiting requested review from celebdor
@rwsu rwsu Awaiting requested review from rwsu
1 more reviewer
@andfasano andfasano andfasano left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@rwsu rwsu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bfournie @andfasano @rwsu @openshift-merge-robot