Use openshift_version function with is_lower_version

[zaneb]

The $OPENSHIFT_VERSION variable isn't defined in CI.

[hardys]

/approve

Minor nit re the FIXME but not blocking on it :)

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [hardys]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vikaslaad]

/retest-required

[hardys]

/lgtm

Merging to unblock nightly promotion

[zaneb]

Looking at the CI logs, we can already see this appears to be operating correctly:

++(ocp_install_env.sh:192): cluster_os_image(): is_lower_version 4.10 4.10
+++(common.sh:34): is_lower_version(): echo '4.10 4.10'
+++(common.sh:34): is_lower_version(): tr ' ' '\n'
+++(common.sh:34): is_lower_version(): sort -V
+++(common.sh:34): is_lower_version(): head -n1
++(common.sh:34): is_lower_version(): [[ 4.10 != 4.10 ]]
++(common.sh:37): is_lower_version(): return 1

I'd be comfortable overriding CI if needed to unblock nightlies.

[zaneb]

Let's try this.
/override ci/prow/e2e-metal-ipi
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-metal-ipi-serial-ipv4
/override ci/prow/e2e-metal-ipi-serial-ovn-ipv6

[openshift-ci]

@zaneb: Overrode contexts on behalf of zaneb: ci/prow/e2e-metal-ipi, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-metal-ipi-serial-ipv4, ci/prow/e2e-metal-ipi-serial-ovn-ipv6

Details

In response to this:

Let's try this.
/override ci/prow/e2e-metal-ipi
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-metal-ipi-serial-ipv4
/override ci/prow/e2e-metal-ipi-serial-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.