Skip to content

MetalLB E2E: Remove export logs flag - #1328

Merged
openshift-merge-robot merged 1 commit into
openshift-metal3:masterfrom
sabinaaledort:remove_flag_metallb_e2e
Dec 9, 2021
Merged

MetalLB E2E: Remove export logs flag#1328
openshift-merge-robot merged 1 commit into
openshift-metal3:masterfrom
sabinaaledort:remove_flag_metallb_e2e

Conversation

@sabinaaledort

Copy link
Copy Markdown
Contributor

Apparently -e flag is getting logs only when running the E2E tests on kind clusters.
We get all the logs we need in must-gather.

@openshift-ci
openshift-ci Bot requested review from russellb and s1061123 December 9, 2021 15:22
Apparently -e flag is getting logs only when running
the E2E tests on kind clusters.
We get all the logs we need in must-gather.
@sabinaaledort
sabinaaledort force-pushed the remove_flag_metallb_e2e branch from 3064248 to b62fee6 Compare December 9, 2021 15:23
@sabinaaledort sabinaaledort changed the title MetalLB E2E: Remove tests reports path flag MetalLB E2E: Remove export logs flag Dec 9, 2021
@msherif1234

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2021
@msherif1234

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Dec 9, 2021

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2021
@fedepaol

fedepaol commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-merge-robot
openshift-merge-robot merged commit 9364cd4 into openshift-metal3:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants