Skip to content

fix: add Bash tool and simplify Claude prompt for skill execution - #93

Merged
rafabene merged 5 commits into
mainfrom
fix/claude-bash-access
Sep 11, 2026
Merged

rafabene merged 5 commits into
mainfrom
fix/claude-bash-access

Conversation

@rafabene

Copy link
Copy Markdown
Member

The /open-prs skill pipeline needs Bash access to run jq commands.

Changes:

  • Added Bash to allowedTools (was: Read,Glob,Grep)
  • Simplified prompt to invoke skill directly
  • Removed step-by-step instruction format

This allows Claude to execute the skill's jq pipelines properly.

… support

- Update actions/checkout from v4.2.2 to v7.0.1
- Update google-github-actions/auth from v2.1.4 to v3.0.0

These versions are fully compatible with Node.js 24 and eliminate all
deprecation warnings in workflow logs.
…access

Claude needs access to GCP credentials to authenticate with Vertex API.
Changed:
- create_credentials_file: true (was false)
- export_environment_variables: true (was false)

This allows the google-github-actions/auth action to create the credential
file and set GOOGLE_APPLICATION_CREDENTIALS so Claude can access it.
Claude can only access files within the job's working directory
(/home/runner/work/hyperfleet-claude-plugins/hyperfleet-claude-plugins).

Changed data file location from /tmp/pr-data.json to pr-data.json.
The /open-prs skill needs Bash access to run jq pipelines.
Updated prompt to invoke the skill directly rather than giving step-by-step instructions.
@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mliptak0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/claude-bash-access
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/claude-bash-access

Comment @coderabbitai help to get the list of available commands.

@rafabene
rafabene merged commit 33452e9 into main Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant