[Backport 2.19-dev] Pin async-query-core publish actions to commit SHAs - #5624
Merged
ahkcs merged 1 commit intoJul 15, 2026
Conversation
ahkcs
requested review from
LantaoJin,
Swiddis,
acarbonetto,
anirudha,
dai-chen,
joshuali925,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws and
ykmr1224
as code owners
July 14, 2026 21:05
Contributor
PR Reviewer Guide 🔍(Review updated until commit 8d3b0f4)Here are some key observations to aid the review process:
|
Signed-off-by: Kai Huang <ahkcs@amazon.com>
ahkcs
force-pushed
the
fix/pin-async-query-publish-actions-2.19-dev
branch
from
July 14, 2026 21:11
3b7e532 to
8d3b0f4
Compare
Contributor
|
Persistent review updated to latest commit 8d3b0f4 |
RyanL1997
approved these changes
Jul 14, 2026
noCharger
approved these changes
Jul 15, 2026
noCharger
left a comment
noCharger
left a comment
Collaborator
There was a problem hiding this comment.
While scanning 2.19-dev, delete_backport_branch.yml still has one unpinned action:
uses: SvanBoxel/delete-merged-branch@main
Branch ref will hit the same "must be pinned to a full-length commit SHA" rejection. Worth a follow-up PR to pin it. Everything else on 2.19-dev is SHA-pinned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pins all actions in
publish-async-query-core.ymlto full commit SHAs, matching the versions pinned onmainby #5464.The 2.19-dev pinning backport #5617 was based on #5573, whose source branch did not contain this workflow, so these five action references remained unpinned. This caused the July 10 async-query-core publication to fail during action preparation: https://github.com/opensearch-project/sql/actions/runs/29123519082
Testing
git diff --checkuses:entry in the workflow is pinned to a full commit SHARelated: #5464, #5573, #5617