Skip to content

Grant BouncyCastle getProperty permission for datasource encryption - #5601

Merged
rishabh6788 merged 1 commit into
opensearch-project:2.19from
dai-chen:fix/datasource-bouncycastle-getproperty-permission
Jul 1, 2026
Merged

Grant BouncyCastle getProperty permission for datasource encryption#5601
rishabh6788 merged 1 commit into
opensearch-project:2.19from
dai-chen:fix/datasource-bouncycastle-getproperty-permission

Conversation

@dai-chen

@dai-chen dai-chen commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR fixed the 2.19.6 release IT failure (#5579) due to the BouncyCastle version bump in opensearch-project/OpenSearch#22296.

Ref to opensearch-project/OpenSearch#17393 and opensearch-project/security#4266, #4270 for the same getProperty.org.bouncycastle.* grant.

Related Issues

Resolves #5579

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • New PPL command checklist all confirmed.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ryption

Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen self-assigned this Jul 1, 2026
@dai-chen dai-chen added the bugFix label Jul 1, 2026
@dai-chen
dai-chen marked this pull request as ready for review July 1, 2026 00:09
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit 563804f.

PathLineSeverityDescription
plugin/src/main/plugin-metadata/plugin-security.policy33lowWildcard SecurityPermission 'getProperty.org.bouncycastle.*' grants read access to all BouncyCastle security properties rather than a specific minimal set. While read-only and scoped to the org.bouncycastle namespace, the wildcard is broader than the principle of least privilege would suggest. The stated justification (datasource credential encryption) is plausible and BouncyCastle is a well-known cryptography library, so this does not indicate malicious intent — but maintainers should confirm no narrower property name can be used instead.

The table above displays the top 10 most important findings.

Total: 1 | Critical: 0 | High: 0 | Medium: 0 | Low: 1


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@rishabh6788
rishabh6788 merged commit 9dc901e into opensearch-project:2.19 Jul 1, 2026
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants