allow partial pushdown for semi-scripted predicates - #5565
Merged
Conversation
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
requested review from
LantaoJin,
RyanL1997,
acarbonetto,
ahkcs,
anirudha,
dai-chen,
joshuali925,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
songkant-aws,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
June 18, 2026 21:41
mengweieric
approved these changes
Jun 19, 2026
asifabashar
pushed a commit
to asifabashar/sql
that referenced
this pull request
Jul 21, 2026
…ct#5565) Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As
likeon text returns unsupported operation exceptions instead of predicate analyzer exceptions, this causes the entire expression pushdown to fail since UOE isn't caught in that process. This applies even if some parts of the expression are applicable. So a query like:Compiles into a single script that filters documents on a full-table scan. With this fix, it's instead compiled into a script to evaluate the LIKE expression, but the
@timestamppredicate is pushed down into DSL:Related Issues
Related to issue 2 identified in #5491
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.