Add new setting to ignore pagination where it is unsupported in V2. - #1997
Closed
Yury-Fridlyand wants to merge 8 commits into
Closed
Add new setting to ignore pagination where it is unsupported in V2.#1997Yury-Fridlyand wants to merge 8 commits into
Yury-Fridlyand wants to merge 8 commits into
Conversation
…318) * Add new setting to ignore pagination where it is unsupported in V2. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Use pagination in correctess tests too. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * spotless Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
marked this pull request as ready for review
August 18, 2023 22:10
Yury-Fridlyand
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
penghuo,
pjfitzgibbons,
ps48,
rupal-bq,
seankao-az and
vamsimanohar
as code owners
August 18, 2023 22:10
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1997 +/- ##
=========================================
Coverage 97.30% 97.30%
- Complexity 4622 4623 +1
=========================================
Files 407 407
Lines 11934 11946 +12
Branches 827 828 +1
=========================================
+ Hits 11612 11624 +12
Misses 315 315
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matthewryanwells
approved these changes
Aug 21, 2023
…/opensearch-project-sql into integ-ignore-pagination-switch Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…tion-switch Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
MitchellGale
approved these changes
Aug 22, 2023
Collaborator
|
Closing as stale -- reopen if needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes how pagination requests with unsupported/incompatible [with pagination] queries are handled.
Adds new setting
plugins.query.ignore_unsupported_pagination:trueby defaulttruesuch requests are performed without paginationfalsesuch requests fall back to legacy engineMisc changes:
Please see team review and discussion in Bit-Quill#318.
The new parameter can be configured by
Issues Resolved
Fixes #1765, #78
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.