Skip to content

[Enhancement] Refactor OpenSearchQueryRequest and OpenSearchScrollRequest so that we pass in includes list from query #1536

Description

@acarbonetto

Is your feature request related to a problem?

When creating the OpenSearchResponse, we don't have access to the OpenSearchQueryRequest or OpenSearchScrollRequest - which is needed for context. Right now, we are picking out the includes list but this is unavailable for scroll requests (which means _id and other metafields are not output on 2+ pages of pagination requests).

What solution would you like?

  1. a way to serialize the includes list that is send to OpenSearch in the request.
  2. a way to pass the serialized includes list to the OpenSearchResponse so that we aren't sending unnecessary information around.
  3. Maybe refactor OpenSearchQueryRequest or OpenSearchScrollRequest to handle/pass this information for both paged and non-paged requests.

What alternatives have you considered?
Related to changes in #1456

Do you have any additional context?
N/A

Metadata

Metadata

Assignees

Labels

maintenanceImproves code quality, but not the product

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions