Skip to content

fix: delete memory items before vector cleanup - #110

Merged
starboyate merged 1 commit into
mainfrom
fix-delete-items-vector-order
May 29, 2026
Merged

starboyate merged 1 commit into
mainfrom
fix-delete-items-vector-order

Conversation

@starboyate

Copy link
Copy Markdown
Collaborator

Summary

  • Delete item store rows before vector cleanup so a failed store delete cannot leave active items without vectors.
  • Keep vector cleanup best-effort after the authoritative store mutation and invalidate retrieval only after the store-delete path succeeds.
  • Add regression coverage for store delete failures, vector cleanup failures, no-vector ids, and operation ordering.

Test Plan

  • mvn -pl memind-core -Dtest=DefaultMemoryTest test
  • mvn -pl memind-core test
  • mvn -pl memind-core spotless:check checkstyle:check
  • git diff --check

Notes

@starboyate
starboyate merged commit 0c2f17d into main May 29, 2026
2 checks passed
@starboyate
starboyate deleted the fix-delete-items-vector-order branch June 5, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant