You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fields of identity records are generated with the ACC_STRICT_INIT flag but the class file corresponding to the record is not marked as using preview features. This bug is fixed in this PR,
Change must be properly reviewed (1 review required, with at least 1 Committer)
Error
⚠️ Pull request body is missing required line: - [x] I confirm that I make this contribution in accordance with the [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
Issue
JDK-8380322: [lworld] Identity records use preview feature (Bug - P2)
👋 Welcome back vromero! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
Anyways, this looks buggy that a driver's main class can be compiled to be preview but jtreg is not running that driver with preview permissiveness. We should report to jtreg.
Anyways, this looks buggy that a driver's main class can be compiled to be preview but jtreg is not running that driver with preview permissiveness. We should report to jtreg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fields of identity records are generated with the ACC_STRICT_INIT flag but the class file corresponding to the record is not marked as using preview features. This bug is fixed in this PR,
TIA
[x] I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.
Progress
Error
- [x] I confirm that I make this contribution in accordance with the [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2302/head:pull/2302$ git checkout pull/2302Update a local copy of the PR:
$ git checkout pull/2302$ git pull https://git.openjdk.org/valhalla.git pull/2302/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2302View PR using the GUI difftool:
$ git pr show -t 2302Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2302.diff
Using Webrev
Link to Webrev Comment