Skip to content

6679: JMC should support project Loom JFR changes#716

Open
aymane-harmaz wants to merge 1 commit intoopenjdk:masterfrom
aymane-harmaz:6679
Open

6679: JMC should support project Loom JFR changes#716
aymane-harmaz wants to merge 1 commit intoopenjdk:masterfrom
aymane-harmaz:6679

Conversation

@aymane-harmaz
Copy link
Copy Markdown
Member

@aymane-harmaz aymane-harmaz commented Apr 13, 2026

This PR :

  • adds the virtual attribute to the Thread structure
  • makes hashCode and equals use the javaThreadId instead of osThreadId as virtual threads will be attached to the osThreadId = 0


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-6679: JMC should support project Loom JFR changes (New Feature - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/716/head:pull/716
$ git checkout pull/716

Update a local copy of the PR:
$ git checkout pull/716
$ git pull https://git.openjdk.org/jmc.git pull/716/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 716

View PR using the GUI difftool:
$ git pr show -t 716

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/716.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 13, 2026

👋 Welcome back aharmaz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 13, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@aymane-harmaz aymane-harmaz marked this pull request as draft April 14, 2026 10:49
@aymane-harmaz
Copy link
Copy Markdown
Member Author

/template append

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 14, 2026

@aymane-harmaz The pull request template has been appended to the pull request body

@aymane-harmaz aymane-harmaz marked this pull request as ready for review April 14, 2026 11:15
@openjdk openjdk Bot added the rfr label Apr 14, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Apr 14, 2026

Webrevs

@thegreystone
Copy link
Copy Markdown
Member

IIRC javaThreadId can be null for native threads that JFR records (GC/VM/JIT threads, etc.). With the new implementation all native threads will be equal to every other native thread. Under the old code, osThreadId distinguished those threads.

@thegreystone
Copy link
Copy Markdown
Member

Also, isVirtual should be in the IMCMethod interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants