8237: Add support for Jolokia over Kubernetes proxy

[skarsaune]

JMC-8273 : Use the jolokia protocol over a kubernetes http proxy.

Testing connectivity:

• Docker desktop kubernetes
• Azure AKS
• Amazon EKS
• Google GKE

Other things observed:

• * Option to install agent should be disabled (debug difference with jolokia) - see below*
• * Warning: NLS missing message: JmcKubernetesPreferenceForm_LogErrorsTooltip in: org.openjdk.jmc.kubernetes.preferences.messages
• * SLF4J(W): No SLF4J providers were found. OK for now, can investigate more later
  SLF4J(W): Defaulting to no-operation (NOP) logger implementation
  SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
• Unlocking secrets now appear on startup. Should not be needed unless there are credentials used. (fixed)

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JMC-8237: Add support for Jolokia over Kubernetes proxy (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/576/head:pull/576
$ git checkout pull/576

Update a local copy of the PR:
$ git checkout pull/576
$ git pull https://git.openjdk.org/jmc.git pull/576/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 576

View PR using the GUI difftool:
$ git pr show -t 576

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/576.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back skarsaune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[bridgekeeper]

@skarsaune This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[skarsaune]

The cause for the log initialization output is calling Utils.getSystemPropertyOrEnvVar . That is only used very briefly for that very particular use. Can look for alternatives.

[skarsaune]

The cause for the log initialization output is calling Utils.getSystemPropertyOrEnvVar . That is only used very briefly for that very particular use. Can look for alternatives.

However, other fabric8.io methods need slf4j quite immediately after that. As the log statement states, it will default to a NOOP logger that we believe is sufficient at this point (problems scanning contexts will manifest themselves as exceptions that should be sufficient to troubleshoot).

[skarsaune]

Found the "issue" with the JMC agent.

public boolean isLocalJvm() { return connectionHandle.getServerDescriptor().getJvmInfo() != null; }
Will experiment with not providing getJvmInfo for jolokia and kubernetes

[bridgekeeper]

@skarsaune This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[skarsaune]

Finding on the Jolokia side. When probing connection k8s API authorization is missing. This can be fixed by using fabric8 http client instead of using OK Http directly.

[openjdk]

@skarsaune this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JMC-8237-kubernetes-proxy
git fetch https://git.openjdk.org/jmc.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[aptmac]

It's stuck on some formatting, it'll fix once you run mvn spotless:apply

[skarsaune]

Setting to draft, and resetting test status boxes. Needs retest now.

[skarsaune]

Hmm, it may be that Kubernetes developments have made this approach not feasible anymore: jolokia/jolokia#989

[skarsaune]

Status update: Things are back to working now 🎉 . Tested successfully both with AKS and GKE. The main struggle has been the 3rd party dependencies after Jolokia became more modular. I need to revisit the third party pom.xml to figure out exactly how much wodoo is needed.
There is also some work on customizing the connections for JMC.