Skip to content

13: Add a remote engine variant to evaluate python script in a remote process#6

Closed
sundararajana wants to merge 2 commits into
openjdk:masterfrom
sundararajana:DETROIT-13
Closed

13: Add a remote engine variant to evaluate python script in a remote process#6
sundararajana wants to merge 2 commits into
openjdk:masterfrom
sundararajana:DETROIT-13

Conversation

@sundararajana
Copy link
Copy Markdown
Member

@sundararajana sundararajana commented May 21, 2026

Adding a remote python engine variant with which we can evaluate, call functions/methods, get/set variables in a remote python process. Please see details in the bug report DETROIT-13


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • DETROIT-13: Add a remote engine variant to evaluate python script in a remote process (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/detroit-python.git pull/6/head:pull/6
$ git checkout pull/6

Update a local copy of the PR:
$ git checkout pull/6
$ git pull https://git.openjdk.org/detroit-python.git pull/6/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6

View PR using the GUI difftool:
$ git pr show -t 6

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/detroit-python/pull/6.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 21, 2026

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 21, 2026

@sundararajana This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

13: Add a remote engine variant to evaluate python script in a remote process

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 21, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 21, 2026

Webrevs

Comment thread src/main/java/org/openjdk/engine/python/PythonScriptEngine.java Outdated
Copy link
Copy Markdown
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much knowledge of the Python multiprocessing APIs, but overall this looks reasonable to me.

I have added a copyright year related comment inline.

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label May 25, 2026
@sundararajana
Copy link
Copy Markdown
Member Author

/integrate

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 25, 2026

Going to push as commit f0e26a5.

@openjdk openjdk Bot added the integrated Pull request has been integrated label May 25, 2026
@openjdk openjdk Bot closed this May 25, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 25, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 25, 2026

@sundararajana Pushed as commit f0e26a5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sundararajana sundararajana deleted the DETROIT-13 branch May 26, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants