ptw: Wait for rvalid on flush#1184
Merged
JeanRochCoulon merged 1 commit intoopenhwgroup:masterfrom Apr 16, 2023
Merged
Conversation
When the PTW is flushed, we need any pending transactions to complete before returning to the IDLE state. Currently, the PTW returns to IDLE after one cycle. Remain in WAIT_RVALID until we have actually received rvalid. Signed-off-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch> Co-authored-by: Marcelo Orenes <movera@princeton.edu> Co-authored-by: Hyunsung Yun <88669963+yuhysu@users.noreply.github.com>
Contributor
|
@zarubaf As MMU is not a very known module from my side, can you approve the modification ? |
zarubaf
approved these changes
Apr 16, 2023
Contributor
zarubaf
left a comment
zarubaf
left a comment
There was a problem hiding this comment.
Thanks and indeed - very strange we never saw an error with that. How did you find this?
Contributor
Author
morenes
added a commit
to morenes/cva6
that referenced
this pull request
Aug 4, 2023
When the PTW is flushed, we need any pending transactions to complete before returning to the IDLE state. Currently, the PTW returns to IDLE after one cycle. Remain in WAIT_RVALID until we have actually received rvalid. Signed-off-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch> Co-authored-by: Marcelo Orenes <movera@princeton.edu> Co-authored-by: Hyunsung Yun <88669963+yuhysu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the PTW is flushed, we need any pending transactions to complete before returning to the
IDLEstate. Currently, the PTW returns toIDLEafter one cycle. Remain inWAIT_RVALIDuntil we have actually receivedrvalid.