fix: import api to chunk file - #734
Merged
Merged
Conversation
KristinAoki
requested review from
connorhaugh,
jesperhodge,
kenclary and
rayzhou-bit
December 7, 2023 21:55
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
==========================================
- Coverage 88.85% 88.83% -0.02%
==========================================
Files 468 468
Lines 7168 7185 +17
Branches 1539 1541 +2
==========================================
+ Hits 6369 6383 +14
- Misses 772 775 +3
Partials 27 27 ☔ View full report in Codecov by Sentry. |
rayzhou-bit
previously approved these changes
Dec 8, 2023
rayzhou-bit
self-requested a review
December 8, 2023 20:11
rayzhou-bit
reviewed
Dec 8, 2023
rayzhou-bit
left a comment
rayzhou-bit
left a comment
Contributor
There was a problem hiding this comment.
This looks good but needs codecov
rayzhou-bit
self-requested a review
December 8, 2023 20:14
rayzhou-bit
approved these changes
Dec 8, 2023
jesperhodge
added a commit
that referenced
this pull request
Dec 12, 2023
This reverts commit 6f7a992.
jesperhodge
added a commit
that referenced
this pull request
Dec 12, 2023
Internal issue: https://2u-internal.atlassian.net/servicedesk/customer/portal/9/CR-6328?created=true Reverted 6 merged PRs due to problems. scroll was not working on editors potential problems with editor content loading ------------------------------------------------------ * Revert "fix(deps): update dependency @edx/frontend-lib-content-components to v1.177.4 (#742)" This reverts commit cc40e9d. * Revert "feat: add escalation email field for LTI-based proctoring providers (#736)" This reverts commit 0f483dc. * Revert "fix: video downloads (#728)" This reverts commit c5abd21. * Revert "fix: import api to chunk file (#734)" This reverts commit 6f7a992. * Revert "feat: Taxonomy delete dialog (#684)" This reverts commit 1eff489. * Revert "fix(deps): update dependency @edx/frontend-lib-content-components to v1.177.1 (#727)" This reverts commit dcabb77.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: TNL-11163
** This PR is dependent on
edx-platformPR #33898 **Testing